Skip RPC fallback for known non-agent users

[realproject7]

Summary

Fixes #600

• Add checkUserExists() helper that checks if any DB row exists for a wallet (regardless of agent_id)
• Agents page and dashboard now distinguish:
  • Known agent (DB row with agent_id != NULL) → use DB, zero RPC calls
  • Known non-agent (DB row with agent_id = NULL) → skip RPC, show registration form
  • Unknown wallet (no DB record) → RPC fallback + auto-cache
• Eliminates 3+ unnecessary agentIdByWallet/balanceOf/tokenOfOwnerByIndex RPC calls per visit for the majority of users who are known non-agents

Test plan

• Known non-agent user visits /agents → no RPC calls, sees Register tab immediately
• Known agent visits /agents → loaded from DB, sees Manage tab
• Unknown wallet visits /agents → RPC fallback fires, auto-caches result
• Build passes

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
plotlink	Ignored		Mar 27, 2026 4:06pm

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The new DB-existence check removes the unnecessary RPC calls for known non-agent users, but it also suppresses the external-agent fallback for any wallet that already has a PlotLink user row.

Findings

• [high] Existing PlotLink users who later register an ERC-8004 agent in another app will now be permanently treated as non-agents, because checkUserExists() is used as a definitive skip-RPC signal even when the local DB cache is stale.
  • File: src/app/agents/page.tsx:33
  • File: src/components/AgentDashboard.tsx:27
  • File: lib/actions.ts:90
  • Suggestion: preserve the no-RPC path for users the app can prove are still non-agents, but do not treat any pre-existing user row as authoritative enough to disable the external-agent fallback forever.

Decision

Issue #600 still requires externally registered agents to be detected and auto-cached on first visit. With this change, that no longer works for users who already have a PlotLink row but registered their ERC-8004 agent elsewhere, so I’m requesting changes.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The lightweight reverse-lookup restores one external-registration case, but it still misses owner-wallet external agents and it does not satisfy issue #600’s zero-RPC requirement for known non-agent users.

Findings

• [high] Known PlotLink users who externally register as NFT owners with a separate or unset agent wallet are still treated as non-agents, because the known-user path only calls agentIdByWallet(address) and never runs the owner lookup fallback.
  • File: src/app/agents/page.tsx:42
  • File: src/app/agents/page.tsx:63
  • File: src/components/AgentDashboard.tsx:36
  • File: src/components/AgentDashboard.tsx:55
  • Suggestion: preserve owner-aware fallback for stale known-user rows too, or introduce another way to distinguish “known local user, stale agent cache” from “definitive non-agent”.
• [medium] Known non-agent users still make an RPC call on every /agents visit, so the ticket’s “zero RPC calls on /agents page” acceptance criterion is still not met.
  • File: src/app/agents/page.tsx:42
  • Suggestion: avoid a per-visit reverse lookup for known non-agents; use an explicit refresh or a cache-invalidation path instead.

Decision

Issue #600 requires known non-agent users to avoid RPC on /agents while still allowing externally registered agents to be detected and auto-cached. This revision still fails both edges, so I’m requesting changes.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The /agents fallback logic now matches issue #600 much more closely, but this revision regresses the cached owner dashboard path.

Findings

• [high] Cached owner dashboards stop loading the agent's storylines when the owner wallet differs from the bound agent wallet, because the DB-backed path no longer swaps writerAddress to the cached agent_wallet.
  • File: src/components/AgentDashboard.tsx:80
  • File: src/components/AgentDashboard.tsx:107
  • Suggestion: restore the previous dbIsOwner && dbAgentWallet assignment so DB-detected owners query storylines with the cached agent wallet rather than the connected owner wallet.

Decision

I’m holding approval because this PR introduces a behavioral regression in AgentDashboard for owners of agents with separate bound wallets, even though the /agents page RPC suppression itself is now on the right track.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The cached owner dashboard regression is fixed, but this PR still removes external-agent detection for existing PlotLink users without actually providing the replacement refresh path it claims.

Findings

• [high] Existing PlotLink users who later register an ERC-8004 agent elsewhere are now permanently treated as non-agents, because the known-user path suppresses all RPC fallback and the referenced /api/user/onboard refresh route does not sync agent cache data.
  • File: src/app/agents/page.tsx:40
  • File: src/components/AgentDashboard.tsx:34
  • File: src/app/api/user/onboard/route.ts:71
  • File: src/app/api/user/onboard/route.ts:106
  • Suggestion: either restore a real agent-sync path for stale known users, or make /api/user/onboard actually refresh and persist ERC-8004 agent state before treating known users as definitively non-agent.

Decision

I can’t approve a regression where existing PlotLink users lose external-agent detection entirely. The zero-RPC optimization is fine, but the replacement path cited in the PR is not implemented.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The new /api/user/onboard sync path is a good direction, but it still only detects direct agent-wallet registrations and misses owner-wallet external agents.

Findings

• [high] Existing PlotLink users who externally register an agent as the NFT owner with a separate or unset bound wallet still remain invisible after profile refresh, because onboarding only calls getAgentMetadata(walletAddress), which resolves via agentIdByWallet(wallet) and returns null for owner-only cases.
  • File: src/app/api/user/onboard/route.ts:118
  • File: lib/contracts/erc8004.ts:246
  • Suggestion: use an owner-aware lookup in the refresh path as well, for example by checking ownership and then resolving metadata by agentId.

Decision

I’m keeping this in request-changes state because the claimed replacement sync path for stale existing users is still incomplete for owner-wallet external registrations.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The new onboarding sync path now covers owner-wallet detection, but it still caches direct bound-wallet registrations incorrectly.

Findings

• [high] Profile refresh caches direct agent-wallet registrations with agent_wallet = NULL, because onboarding writes agentMeta.agentWallet after calling getAgentMetadata(wallet), and that helper does not populate agentWallet for the direct-wallet path. On the next DB-backed /agents load, the bound wallet is misclassified as the owner role and gets owner-only management UI.
  • File: src/app/api/user/onboard/route.ts:121
  • File: src/app/api/user/onboard/route.ts:154
  • File: lib/contracts/erc8004.ts:271
  • File: src/app/agents/page.tsx:77
  • File: src/components/AgentManage.tsx:293
  • Suggestion: when onboarding finds an agent via getAgentMetadata(normalizedAddress), persist agent_wallet: normalizedAddress directly, or have getAgentMetadata() return agentWallet: walletAddress for the bound-wallet case.

Decision

I’m keeping this in request-changes state because the explicit refresh path still corrupts role detection for existing PlotLink users who externally register as direct agent wallets.

[project7-interns]

Verdict: APPROVE

Summary

The /agents page now skips RPC for known non-agent users while preserving full fallback for unknown wallets, and the new onboarding sync path covers both bound-wallet and owner-wallet external registrations without breaking DB-backed role detection.

Findings

• None.

Decision

This now satisfies issue #600’s acceptance criteria: known non-agents stay zero-RPC on page load, known agents remain DB-backed, unknown wallets still use RPC fallback, and external registrations have a concrete sync path that correctly populates the agent cache.