Fix Farcaster web share embed rendering#603
Merged
realproject7 merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Use separate embeds[] query parameter for the story URL in the Farcaster web compose fallback instead of embedding the URL in the text body. This enables proper link preview/embed rendering on Farcaster. Miniapp SDK path unchanged. X/Twitter share unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 27, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR is correctly scoped to issue #598 and fixes the Farcaster web fallback by moving the story URL into the embeds[] parameter while leaving the miniapp SDK path unchanged.
Findings
- None.
Decision
This satisfies the requested Farcaster web share fix without introducing unrelated changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #598
embeds[]query parameter for the story URL instead of appending it to the text bodycomposeCastpath unchanged (already usesembedsarray)Test plan
🤖 Generated with Claude Code