Show connected wallet alongside Farcaster profile#619
Conversation
When a Farcaster identity is connected, show the truncated wallet address as secondary muted text next to the @username. Hidden on mobile (sm:inline) to keep the nav compact. Address updates automatically when wallets switch via wagmi's useAccount hook. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The PR is narrowly scoped to the connected-state wallet UI, but it currently drops the new wallet-address detail on mobile instead of making it mobile-safe.
Findings
- [medium] The connected wallet address is hidden completely on small screens, so the mobile view still does not show which wallet is connected when a Farcaster profile is present.
- File:
src/components/ConnectWallet.tsx:59 - Suggestion: keep the wallet visible in a compact mobile-safe form instead of
hidden sm:inlineso issue #614's "connected wallet address visible alongside Farcaster profile" requirement is met on mobile too.
- File:
Decision
Requesting changes because the current implementation satisfies the desktop version of the feature, but not the mobile acceptance criterion.
Remove hidden sm:inline — wallet address now always visible alongside Farcaster profile. Reduced to text-[10px] for compact mobile display. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The updated connected-state wallet UI now keeps the Farcaster identity primary while showing the truncated connected wallet as secondary text in both desktop and the mobile dropdown path.
Findings
- None.
Decision
Approved because the revised ConnectWallet implementation now satisfies issue #614: the wallet address remains visible alongside the Farcaster profile, stays compact on mobile, and still updates from the connected wagmi account when wallets switch.
2 participants
Summary
Fixes #614
@usernamein the connected-state nav UIhidden sm:inline) to keep nav compactuseAccounthookTest plan
@username+ truncated wallet address on desktop🤖 Generated with Claude Code