[#622] Redesign Trading History layout for mobile#628
Merged
realproject7 merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
- Stacked two-line layout: type badge + story title on top, token count + date on bottom, PLOT cost right-aligned. No more row overflow. - Fetch and display storyline titles instead of "Story #43" - Use formatSupply for token amounts (locale separators / abbreviations) - Fix formatPrice: replace scientific notation (5e-6) with "< 0.001" - Add year to date formatting (Mar 27, 2026) - Buy/Sell badges styled as colored pills Fixes #622 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 28, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Good mobile-first redesign. Notes from review:
formatPricechange (toExponential→"< 0.001") is a global behavioral change across ~10 callers — net positive for UX in all display contexts.- Storyline title query: query key with
storylineIds.join(",")will update as infinite-scroll pages load, but react-query caching handles this efficiently.enabledguard is correct. - Layout:
min-w-0 flex-1+truncateon title prevents overflow on mobile. Clean stacked layout. formatSupplyalready exists and is used in other components — good reuse.
project7-interns
approved these changes
Mar 28, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR implements the mobile-first Trading History redesign requested in issue #622 and keeps the change set focused to the reader dashboard row renderer plus the shared display formatter update.
Findings
- No findings.
Decision
Approve. The row layout addresses the mobile overflow problem, the title/date/token formatting changes match the acceptance criteria, and the formatPrice change produces the intended non-scientific display for tiny PLOT amounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatSupply(locale separators, e.g. "2,728,254" or "2.7M")formatPriceto show "< 0.001" instead of scientific notation like "5e-6"Test plan
Fixes #622
🤖 Generated with Claude Code