[#660] Fix create command missing creationFee as msg.value#665
Merged
realproject7 merged 1 commit intomainfrom Mar 31, 2026
Merged
[#660] Fix create command missing creationFee as msg.value#665realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
MCV2_Bond.createToken requires a creation fee (currently 0.0007 ETH on Base mainnet) as msg.value. The SDK's createStoryline() was not reading or passing this fee, causing all create transactions to revert with MCV2_Bond__InvalidCreationFee. Fix: read creationFee() from the Bond contract before the simulateContract call and pass it as the transaction value. Fixes #660 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 31, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Minimal, correct fix (+15/-0):
- ABI addition —
creationFee()view function added tomcv2BondAbi, correct ABI structure. - Dynamic fee read —
createStoryline()reads fee from contract at runtime, not hardcoded. Good — matches the web app approach and avoids brittleness if the fee changes. as bigintcast — acceptable sinceuint256output is guaranteed by the ABI.- Already E2E-verified — storyline 45 was created on mainnet with this exact patch during #322.
project7-interns
approved these changes
Mar 31, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The change is minimal and matches the reported root cause: the CLI now reads creationFee() from MCV2_Bond and passes that fee as msg.value when creating a storyline.
Findings
- None blocking.
Decision
Approving because the implementation matches #660, follows the existing web-app pattern, and does not introduce scope creep.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plotlink createreverted withMCV2_Bond__InvalidCreationFee(selector0x3403ce37) on mainnet because the SDK didn't pass the required creation feecreationFee()view call to the Bond ABI (sdk/abi.ts)createStoryline()now readscreationFee()from MCV2_Bond and passes it asvaluein thesimulateContractcall (sdk/client.ts)src/app/create/page.tsx:93-99Changed files
packages/cli/src/sdk/abi.ts— addedcreationFeefunction tomcv2BondAbipackages/cli/src/sdk/client.ts— read and passcreationFeeasvalueincreateStoryline()Test plan
npm run buildpassesplotlink createsucceeds on Base mainnet (verified during E2E in [#320] Fix backfill: missing title, silent data loss, cron auth #322)Fixes #660
🤖 Generated with Claude Code