Merge Writer Dashboard into Profile Stories tab#689
Conversation
- Profile Stories tab now shows full writer dashboard content (genre editing, claim royalties, trading stats, deadline countdown, donation history) when viewing own profile - Other users' profiles show storylines read-only with token price + TVL - Fix BigInt(0) rendering bug in wallet card (claimedRoyalties != null check) - /writer page now redirects to /profile/[address]?tab=stories - Profile page reads ?tab= query param for deep linking Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Clean consolidation: writer dashboard content moved into Profile Stories tab with proper isOwnProfile gating, /writer redirects to profile, BigInt(0) bug fixed. All acceptance criteria from #683 met.
Minor: getTokenTVL is imported in profile/[address]/page.tsx but doesn't appear to be used directly — tree shaking handles it, but could be cleaned up. Not blocking.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The migration is close, but two pieces of the writer-dashboard behavior are still off in the merged Stories tab. One required writer metric disappeared, and one writer-only panel now leaks onto other users' profiles.
Findings
-
[medium] The merged
StoryRowno longer renders the per-storyDonationsmetric from the old writer dashboard, so the own-profile Stories tab is missing one of the required storyline-card fields from #683.- File:
src/app/profile/[address]/page.tsx:832 - Suggestion: Restore the fourth storyline-card field to
Donationsby porting the oldDonationCountdisplay from the writer dashboard instead of leaving the card with only plots/price/holders/views.
- File:
-
[medium]
DeadlineCountdownis rendered for every active storyline, even on someone else's profile. Requirement #2 says other profiles should stay read-only and only show the stripped-down story card plus token price/TVL.- File:
src/app/profile/[address]/page.tsx:869 - Suggestion: Gate the countdown with
isOwnProfileso only the owner sees the writer-dashboard deadline panel.
- File:
Decision
Requesting changes because the current Stories tab still misses a required writer-dashboard field and exposes a writer-only widget on read-only profile views.
… add donations field - DeadlineCountdown now only shows on own profile (was showing on all profiles) - Added per-story donation count/total to own-profile story cards Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Deployment failed with the following error: |
project7-interns
left a comment
There was a problem hiding this comment.
Re-review: both fixes confirmed. DeadlineCountdown now gated behind isOwnProfile, StoryDonationCount added for own-profile story cards. LGTM.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The latest head addresses the two blockers from the previous review. The merged Stories tab now restores the per-story donations field for own-profile cards and keeps DeadlineCountdown owner-only on read-only profile views.
Findings
- None.
Decision
Approving because the current revision now matches the writer-dashboard merge requirements from #683, including the owner-only writer controls and the corrected profile-view behavior.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
claimedRoyalties != nullcheck prevents stray "0" rendering/writerredirects to/profile/[address]?tab=stories?tab=query param for deep linkingFixes #683
Test plan
/writerredirects to profilenpm run buildpasses ✅🤖 Generated with Claude Code