Skip to content

Merge Writer Dashboard into Profile Stories tab#689

Merged
realproject7 merged 4 commits intomainfrom
task/683-merge-writer-dashboard
Mar 31, 2026
Merged

Merge Writer Dashboard into Profile Stories tab#689
realproject7 merged 4 commits intomainfrom
task/683-merge-writer-dashboard

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Profile Stories tab now shows full writer dashboard content when viewing own profile: genre editing, claim royalties, trading stats, deadline countdown, donation history
  • Other users' profiles show storylines read-only with token price + TVL (no claim, no edit, no donation details)
  • Fix BigInt(0) bug in wallet card — claimedRoyalties != null check prevents stray "0" rendering
  • /writer redirects to /profile/[address]?tab=stories
  • Profile page reads ?tab= query param for deep linking

Fixes #683

Test plan

  • Profile Stories tab shows full writer dashboard content (own profile)
  • Claim royalties button works on own profile
  • Genre/language editing works on own profile
  • Other users' profiles show storylines read-only (no claim, no edit)
  • Wallet card no longer shows stray "0"
  • /writer redirects to profile
  • USD values still display correctly
  • npm run build passes ✅

🤖 Generated with Claude Code

- Profile Stories tab now shows full writer dashboard content (genre editing,
  claim royalties, trading stats, deadline countdown, donation history) when
  viewing own profile
- Other users' profiles show storylines read-only with token price + TVL
- Fix BigInt(0) rendering bug in wallet card (claimedRoyalties != null check)
- /writer page now redirects to /profile/[address]?tab=stories
- Profile page reads ?tab= query param for deep linking

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Mar 31, 2026 8:43pm

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean consolidation: writer dashboard content moved into Profile Stories tab with proper isOwnProfile gating, /writer redirects to profile, BigInt(0) bug fixed. All acceptance criteria from #683 met.

Minor: getTokenTVL is imported in profile/[address]/page.tsx but doesn't appear to be used directly — tree shaking handles it, but could be cleaned up. Not blocking.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The migration is close, but two pieces of the writer-dashboard behavior are still off in the merged Stories tab. One required writer metric disappeared, and one writer-only panel now leaks onto other users' profiles.

Findings

  • [medium] The merged StoryRow no longer renders the per-story Donations metric from the old writer dashboard, so the own-profile Stories tab is missing one of the required storyline-card fields from #683.

    • File: src/app/profile/[address]/page.tsx:832
    • Suggestion: Restore the fourth storyline-card field to Donations by porting the old DonationCount display from the writer dashboard instead of leaving the card with only plots/price/holders/views.
  • [medium] DeadlineCountdown is rendered for every active storyline, even on someone else's profile. Requirement #2 says other profiles should stay read-only and only show the stripped-down story card plus token price/TVL.

    • File: src/app/profile/[address]/page.tsx:869
    • Suggestion: Gate the countdown with isOwnProfile so only the owner sees the writer-dashboard deadline panel.

Decision

Requesting changes because the current Stories tab still misses a required writer-dashboard field and exposes a writer-only widget on read-only profile views.

… add donations field

- DeadlineCountdown now only shows on own profile (was showing on all profiles)
- Added per-story donation count/total to own-profile story cards

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 31, 2026

Deployment failed with the following error:

Invalid request: `attribution.gitUser` should NOT have additional property `isBot`.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: both fixes confirmed. DeadlineCountdown now gated behind isOwnProfile, StoryDonationCount added for own-profile story cards. LGTM.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The latest head addresses the two blockers from the previous review. The merged Stories tab now restores the per-story donations field for own-profile cards and keeps DeadlineCountdown owner-only on read-only profile views.

Findings

  • None.

Decision

Approving because the current revision now matches the writer-dashboard merge requirements from #683, including the owner-only writer controls and the corrected profile-view behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@realproject7 realproject7 merged commit fd0139a into main Mar 31, 2026
3 of 4 checks passed
@realproject7 realproject7 deleted the task/683-merge-writer-dashboard branch March 31, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[#682] Sub-1: Merge Writer Dashboard into Profile Stories tab

2 participants