Skip to content

Redesign Portfolio tab — compact layout with collapsible sections#707

Merged
realproject7 merged 2 commits intomainfrom
task/700-portfolio-tab-redesign
Apr 1, 2026
Merged

Redesign Portfolio tab — compact layout with collapsible sections#707
realproject7 merged 2 commits intomainfrom
task/700-portfolio-tab-redesign

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Portfolio summary: compact horizontal row (value, token count, best 24h pick inline)
  • Token holdings: inline stats per card with middot separators (balance, price, entry, date)
  • Donations: unified card with received summary + collapsible given breakdown
  • Removed confusing "total loaded" text
  • Trading history: collapsible <details> with compact inline rows
  • Consistent card styling throughout all sections

Fixes #700

Self-Verification

  • All current information still displayed (nothing removed)
  • Portfolio value, holdings, donations, trades all present
  • Own profile vs public profile views both work
  • Mobile (375px): clean, no overflow — inline stats wrap naturally
  • Desktop: good use of horizontal space
  • Consistent card/section styling throughout
  • Matches PlotLink terminal aesthetic
  • npm run build passes

🤖 Generated with Claude Code

…llapsible sections

- Portfolio summary: compact horizontal row with value, token count, best 24h pick
- Token holdings: inline stats per card (balance, price, entry, date) with middot separators
- Donations: unified card for received + given, donations given collapsible
- Removed confusing "total loaded" text from donations given header
- Trading history: collapsible with compact inline rows (buy/sell, title, amount, date)
- Consistent border-border card styling throughout

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 1, 2026 11:16am

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Solid Portfolio tab redesign. All #700 criteria verified:

  • ✅ All info preserved — portfolio value, holdings, donations, trading history all present
  • ✅ Portfolio summary: grid → compact horizontal flex-wrap row (value, token count, best 24h)
  • ✅ Token holdings: inline stats with middot separators, consistent card styling
  • ✅ Donations: unified card grouping received + given; given section is collapsible <details>
  • ✅ "total loaded" text removed
  • ✅ Trading history: collapsible <details> (open by default), compact single-row trades
  • ✅ Own profile vs public profile: isOwnProfile guards intact
  • ✅ Mobile responsive: flex-wrap with gap for natural wrapping
  • ✅ Consistent card styling throughout all sections
  • ✅ Build passes

Minor note: trading history date drops year (now "short month + day" only). Acceptable trade-off for compact rows.

+219/−235, single file. No blocking concerns.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The portfolio layout is cleaner, but the holdings rewrite drops required unit information from the per-token price fields.

Findings

  • [medium] The inline holdings stats no longer show the reserve unit on current price and entry price. Issue #700 requires both fields to be displayed as PLOT + USD, and the previous implementation included ${RESERVE_LABEL} for each. In the new row they render only the numeric value plus optional USD, which makes those prices ambiguous and removes required information.
    • File: src/app/profile/[address]/page.tsx:1468
    • Suggestion: Restore ${RESERVE_LABEL} on both the price and entry values in the holdings row so each token card still shows current price and entry price as PLOT + USD.

Decision

Requesting changes because the redesign currently omits required unit information from the token holdings section.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up revision addresses the missing unit label regression and keeps the portfolio redesign aligned with issue #700.

Findings

  • None.

Decision

The holdings rows now show current price and entry price in the required PLOT + USD format again, and the rest of the compact portfolio layout remains consistent with the redesign goals. I am approving.

@realproject7 realproject7 merged commit 037eb9a into main Apr 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign Portfolio tab layout — tidy up holdings, donations, trading history

2 participants