Skip to content

Stories tab v4 — structured label-value grid layout #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 3 commits into from
Apr 1, 2026
Merged

Stories tab v4 — structured label-value grid layout #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf8853d
[#724] Stories tab v4 — structured label-value grid layout
realproject7 Apr 1, 2026
6b06487
[#724] Fix T2a review: remove duplicate price row, grid-ify donations
realproject7 Apr 1, 2026
bcc0ea6
[#724] Fix WriterTradingStats: grid-cols-[auto_1fr] label-value rows
realproject7 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 106 additions & 90 deletions src/app/profile/[address]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import { getFullUserProfile } from "../../../../lib/actions";
import { truncateAddress } from "../../../../lib/utils";
import { formatPrice, formatSupply } from "../../../../lib/format";
import { getTokenPrice, mcv2BondAbi, erc20Abi, type TokenPriceInfo, get24hPriceChange, getTokenTVL } from "../../../../lib/price";

Check warning on line 14 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'TokenPriceInfo' is defined but never used
import { browserClient } from "../../../../lib/rpc";
import type { FarcasterProfile } from "../../../../lib/farcaster";
import type { AgentMetadata } from "../../../../lib/contracts/erc8004";
Expand Down Expand Up @@ -133,7 +133,7 @@
if (r <= 0) clearInterval(interval);
}, 1000);
return () => clearInterval(interval);
}, [dbUser?.steemhunt_fetched_at]);

Check warning on line 136 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

React Hook useEffect has a missing dependency: 'COOLDOWN_MS'. Either include it or remove the dependency array

const onCooldown = cooldownRemaining > 0;

Expand Down Expand Up @@ -677,44 +677,50 @@

return (
<div className="mt-6 space-y-4">
{/* Writer Stats — compact horizontal row */}
<div className="border-border rounded border px-4 py-3">
<div className="flex flex-wrap items-baseline gap-x-4 gap-y-1 text-xs">
<span className="text-muted text-[10px] uppercase tracking-wider">Writer</span>
<span className="text-foreground font-medium">{storylines.length}</span>
<span className="text-muted">stories</span>
<span className="text-muted">&middot;</span>
<span className="text-foreground font-medium">{totalPlots}</span>
<span className="text-muted">plots</span>
<span className="text-muted">&middot;</span>
<span className="text-foreground font-medium">{totalHolders !== undefined ? totalHolders : "—"}</span>
<span className="text-muted">holders</span>
<span className="text-muted">&middot;</span>
{totalDonations > BigInt(0) ? (
<>
<span className="text-foreground font-medium">{formatPrice(formatUnits(totalDonations, 18))} {RESERVE_LABEL}</span>
{plotUsd != null && (
<span className="text-muted">(≈ {formatUsdValue(Number(formatUnits(totalDonations, 18)) * plotUsd)})</span>
)}
</>
) : (
<span className="text-foreground font-medium">—</span>
)}
<span className="text-muted">donated</span>
{/* Writer Stats — structured grid */}
<div className="border-border rounded border px-4 py-3 text-xs">
<p className="text-muted mb-2 text-[10px] uppercase tracking-wider">Writer Stats</p>
<div className="grid grid-cols-2 gap-x-4 gap-y-1">
<div className="grid grid-cols-[auto_1fr] gap-x-2">
<span className="text-muted">Stories</span>
<span className="text-foreground text-right font-medium">{storylines.length}</span>
</div>
<div className="grid grid-cols-[auto_1fr] gap-x-2">
<span className="text-muted">Plots</span>
<span className="text-foreground text-right font-medium">{totalPlots}</span>
</div>
<div className="grid grid-cols-[auto_1fr] gap-x-2">
<span className="text-muted">Holders</span>
<span className="text-foreground text-right font-medium">{totalHolders !== undefined ? totalHolders : "—"}</span>
</div>
<div className="grid grid-cols-[auto_1fr] gap-x-2">
<span className="text-muted">Views</span>
<span className="text-foreground text-right font-medium">
{storylines.reduce((sum, s) => sum + (s.view_count ?? 0), 0)}
</span>
</div>
</div>
<div className="mt-1 grid grid-cols-[auto_1fr] gap-x-2 gap-y-1">
<span className="text-muted">Donated</span>
<span className="text-foreground text-right font-medium">
{totalDonations > BigInt(0)
? `${formatPrice(formatUnits(totalDonations, 18))} ${RESERVE_LABEL}`
: "—"}
{totalDonations > BigInt(0) && plotUsd != null && (
<span className="text-muted font-normal"> ({formatUsdValue(Number(formatUnits(totalDonations, 18)) * plotUsd)})</span>
)}
</span>
{isOwnProfile && royaltyInfo && (
<>
<span className="text-muted">&middot;</span>
{royaltyInfo.unclaimed > BigInt(0) ? (
<>
<span className="text-accent font-medium">{formatPrice(formatUnits(royaltyInfo.unclaimed, 18))} {RESERVE_LABEL}</span>
{plotUsd != null && (
<span className="text-muted">(≈ {formatUsdValue(Number(formatUnits(royaltyInfo.unclaimed, 18)) * plotUsd)})</span>
)}
</>
) : (
<span className="text-foreground font-medium">—</span>
)}
<span className="text-muted">claimable</span>
<span className="text-muted">Claimable</span>
<span className="text-accent text-right font-medium">
{royaltyInfo.unclaimed > BigInt(0)
? `${formatPrice(formatUnits(royaltyInfo.unclaimed, 18))} ${RESERVE_LABEL}`
: "—"}
{royaltyInfo.unclaimed > BigInt(0) && plotUsd != null && (
<span className="text-muted font-normal"> ({formatUsdValue(Number(formatUnits(royaltyInfo.unclaimed, 18)) * plotUsd)})</span>
)}
</span>
</>
)}
</div>
Expand Down Expand Up @@ -778,7 +784,7 @@
}) {
const tokenAddr = storyline.token_address as Address;

const { data: priceInfo } = useQuery({

Check warning on line 787 in src/app/profile/[address]/page.tsx

View workflow job for this annotation

GitHub Actions / lint-and-typecheck 

'priceInfo' is assigned a value but never used
queryKey: ["profile-story-price", storyline.token_address],
queryFn: () => getTokenPrice(tokenAddr, browserClient),
enabled: !!storyline.token_address,
Expand Down Expand Up @@ -823,77 +829,78 @@
});

return (
<div className="border-b border-border pb-4">
{/* Primary: title + badges + price */}
<div className="flex flex-wrap items-baseline gap-x-2 gap-y-1">
<div className="border-border rounded border divide-y divide-border text-xs">
{/* Title section */}
<div className="px-4 py-3">
<Link
href={`/story/${storyline.storyline_id}`}
className="text-foreground hover:text-accent text-sm font-medium transition-colors"
>
{storyline.title}
</Link>
{storyline.genre && (
<span className="bg-accent/10 text-accent rounded px-1.5 py-0.5 text-[9px] font-medium">
{storyline.genre}
</span>
)}
{storyline.sunset ? (
<span className="text-muted text-[9px]">complete</span>
) : (
<span className="text-green-700 text-[9px]">active</span>
)}
{priceInfo && (
<span className="text-foreground text-xs font-medium ml-auto shrink-0">
{formatPrice(priceInfo.pricePerToken)} {RESERVE_LABEL}
{plotUsd != null && (
<span className="text-muted font-normal"> (≈ {formatUsdValue(Number(priceInfo.pricePerToken) * plotUsd)})</span>
)}
</span>
)}
</div>

{/* Secondary: compact stats */}
<div className="text-muted mt-1 flex flex-wrap gap-x-2 gap-y-0.5 text-[11px]">
<span>{storyline.plot_count} {storyline.plot_count === 1 ? "plot" : "plots"}</span>
<span>&middot;</span>
<span>{holderCount !== undefined ? `${holderCount} ${holderCount === 1 ? "holder" : "holders"}` : "—"}</span>
<span>&middot;</span>
<span>{formatViewCount(storyline.view_count)} views</span>
{storyline.block_timestamp && (
<>
<span>&middot;</span>
<span>{new Date(storyline.block_timestamp).toLocaleDateString("en-US", { month: "short", day: "numeric", year: "numeric" })}</span>
</>
)}
<div className="mt-0.5 flex items-center gap-2 text-[11px]">
{storyline.genre && <span className="text-muted">{storyline.genre}</span>}
{storyline.sunset ? (
<span className="text-muted">complete</span>
) : (
<span className="text-green-700">active</span>
)}
</div>
</div>

{/* TVL + donations */}
{storyline.token_address && (
<div className="mt-1.5 space-y-1">
{/* Stats grid */}
<div className="px-4 py-3 space-y-2">
{storyline.token_address && (
<WriterTradingStats storyline={storyline} plotUsd={plotUsd} />
<StoryDonationCount storylineId={storyline.storyline_id} tokenAddress={storyline.token_address} />
)}
<div className="grid grid-cols-2 gap-x-4 gap-y-1 text-xs">
<div className="grid grid-cols-[auto_1fr] gap-x-2">
<span className="text-muted">Plots</span>
<span className="text-foreground text-right font-medium">{storyline.plot_count}</span>
</div>
<div className="grid grid-cols-[auto_1fr] gap-x-2">
<span className="text-muted">Holders</span>
<span className="text-foreground text-right font-medium">{holderCount ?? "—"}</span>
</div>
<div className="grid grid-cols-[auto_1fr] gap-x-2">
<span className="text-muted">Views</span>
<span className="text-foreground text-right font-medium">{formatViewCount(storyline.view_count)}</span>
</div>
<div className="grid grid-cols-[auto_1fr] gap-x-2">
<span className="text-muted">Created</span>
<span className="text-foreground text-right font-medium">
{storyline.block_timestamp
? new Date(storyline.block_timestamp).toLocaleDateString("en-US", { month: "short", year: "2-digit" })
: "—"}
</span>
</div>
</div>
)}
{storyline.token_address && (
<StoryDonationCount storylineId={storyline.storyline_id} tokenAddress={storyline.token_address} />
)}
</div>

{/* Deadline */}
{!storyline.sunset && storyline.last_plot_time && (
<div className="mt-1.5">
<div className="px-4 py-2">
<DeadlineCountdown lastPlotTime={storyline.last_plot_time} />
</div>
)}

{/* Owner-only: genre edit, royalties, donation history */}
{/* Genre prompt — own profile */}
{isOwnProfile && !storyline.genre && (
<div className="mt-2">
<div className="px-4 py-2">
<GenrePrompt
storylineId={storyline.storyline_id}
language={storyline.language}
writerAddress={writerAddress}
/>
</div>
)}

{/* Royalties + Claim — own profile */}
{isOwnProfile && storyline.token_address && (
<div className="mt-2">
<div className="px-4 py-2">
<ClaimRoyalties
tokenAddress={storyline.token_address as Address}
plotCount={storyline.plot_count}
Expand All @@ -902,8 +909,12 @@
/>
</div>
)}

{/* Donation history — own profile */}
{isOwnProfile && storyline.token_address && (
<ProfileDonationHistory storylineId={storyline.storyline_id} />
<div className="px-4 py-2">
<ProfileDonationHistory storylineId={storyline.storyline_id} />
</div>
)}
</div>
);
Expand Down Expand Up @@ -1133,19 +1144,24 @@
});

if (!data || data.count === 0) {
return <div className="text-muted text-xs">No donations</div>;
return (
<div className="grid grid-cols-[auto_1fr] gap-x-3 text-xs">
<span className="text-muted">Donations</span>
<span className="text-foreground text-right font-medium">—</span>
</div>
);
}

return (
<div className="text-xs">
<span className="text-muted text-[10px] uppercase tracking-wider">Donations</span>
<span className="text-foreground ml-2 font-medium">
<div className="grid grid-cols-[auto_1fr] gap-x-3 text-xs">
<span className="text-muted">Donations</span>
<span className="text-foreground text-right font-medium">
{formatPrice(formatUnits(data.total, 18))} {RESERVE_LABEL}
{plotUsd != null && (
<span className="text-muted font-normal"> ({formatUsdValue(Number(formatUnits(data.total, 18)) * plotUsd)})</span>
)}
<span className="text-muted font-normal"> &times;{data.count}</span>
</span>
{plotUsd != null && (
<span className="text-muted"> (≈ {formatUsdValue(Number(formatUnits(data.total, 18)) * plotUsd)})</span>
)}
<span className="text-muted"> ({data.count})</span>
</div>
);
}
Expand Down
34 changes: 13 additions & 21 deletions src/components/WriterTradingStats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,32 +43,24 @@ export function WriterTradingStats({ storyline, plotUsd }: WriterTradingStatsPro
});

return (
<div className="text-muted grid grid-cols-2 gap-2 text-xs">
<div>
<span className="block text-[10px] uppercase tracking-wider">
Token Price
</span>
<span className="font-semibold text-accent">
<div className="space-y-1 text-xs">
<div className="grid grid-cols-[auto_1fr] gap-x-3">
<span className="text-muted">Price</span>
<span className="text-foreground text-right font-medium">
{data ? `${formatPrice(data.price)} ${RESERVE_LABEL}` : "—"}
{data && plotUsd && (
<span className="text-muted font-normal"> ({formatUsdValue(parseFloat(data.price) * plotUsd)})</span>
)}
</span>
{data && plotUsd && (
<span className="text-muted ml-1 text-[10px]">
(≈ {formatUsdValue(parseFloat(data.price) * plotUsd)})
</span>
)}
</div>
<div>
<span className="block text-[10px] uppercase tracking-wider">
TVL
</span>
<span className="font-semibold text-accent">
<div className="grid grid-cols-[auto_1fr] gap-x-3">
<span className="text-muted">TVL</span>
<span className="text-foreground text-right font-medium">
{data ? `${formatPrice(data.tvl)} ${RESERVE_LABEL}` : "—"}
{data && plotUsd && (
<span className="text-muted font-normal"> ({formatUsdValue(parseFloat(data.tvl) * plotUsd)})</span>
)}
</span>
{data && plotUsd && (
<span className="text-muted ml-1 text-[10px]">
(≈ {formatUsdValue(parseFloat(data.tvl) * plotUsd)})
</span>
)}
</div>
</div>
);
Expand Down
Loading