Portfolio tab v4 — structured label-value grid layout#727
Conversation
Portfolio summary: grid-cols-[auto_1fr] for Value/Tokens/Best 24h Holdings: bordered cards with grid-cols-[auto_1fr] for all stats (Value, Change, Balance, Price, Entry, Traded) Donations: structured grid for Received/Given totals, grid rows for per-story breakdown Trades: two-line per trade (Buy/Sell + title, then tokens + amount + date in grid) No inline flex-wrap — all data in predictable grid positions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Follows the #725 wireframe precisely. All criteria met:
Portfolio Summary:
- ✅
grid-cols-[auto_1fr]for Value/Tokens/Best 24h
Holdings:
- ✅ Bordered cards with
grid-cols-[auto_1fr]for all stats (Value, Change, Balance, Price, Entry, Traded) - ✅ Genre as inline muted text (not badge) — won't break layout
Donations:
- ✅ Structured
grid-cols-[auto_1fr]for Received/Given with sub-count rows - ✅ Per-story rows:
grid-cols-[auto_1fr_auto]— story / amount / date+link
Trades:
-
✅ Two-line format: action + title, then
grid-cols-[auto_1fr_auto]for tokens/amount/date -
✅
divide-ybetween trades -
✅ Zero
flex-wrapfor stats — all predictable grid positions -
✅ Numbers right-aligned, USD in muted
-
✅ Build passes
+155/−180, single file. No concerns.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The portfolio summary, holdings, and donation sections are much closer to the wireframe, but the trading-history rows still miss one part of issue #725's exact mobile layout.
Findings
- [medium] The trade rows still place the date and tx link in the same
grid-cols-[auto_1fr_auto]metadata row as the token count and amount, instead of rendering the date/link on their own line below. That leaves each trade at a two-line layout rather than the three-line wireframe requested in issue #725 and makes the right edge more prone to crowding on 375px.- File:
src/app/profile/[address]/page.tsx:1600 - Suggestion: keep the current first line for action + title, keep the second line for token count and amount/USD, then move the date + tx link into a separate third row aligned like the wireframe.
- File:
Decision
Issue #725 explicitly asks for the exact mobile wireframe and calls for the trade row's date/link to sit below the amount row, so I'm requesting one more layout adjustment before approval.
Row 1: Buy/Sell + title Row 2: token count + amount (grid-cols-[auto_1fr]) Row 3: date + tx link Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up revision fixes the remaining trade-row layout issue and brings the portfolio tab in line with issue #725's structured mobile wireframe.
Findings
- None.
Decision
The trading-history rows now render as action/title, then tokens + amount, then a separate date/link row, which resolves my prior finding. I am approving.
Summary
grid-cols-[auto_1fr]for Value, Tokens, Best 24hgrid-cols-[auto_1fr]for all stats (Value, Change, Balance, Price, Entry, Traded)grid-cols-[auto_1fr_auto]for per-story rowsFixes #725
Self-Verification
npm run buildpasses🤖 Generated with Claude Code