[#756] Reader holdings: replace inline stats with 4-box grid

[realproject7]

Summary

• Replaces inline label-value stats (Balance, Price, Entry, Traded) in Reader holdings cards with a 2×2 stat-box grid matching the Writer tab pattern
• Value: USD only with 24h price % change (green/red coloring)
• Balance: compact K/M format (e.g. 240K, 1.5M)
• PnL: USD profit/loss with %, or "—" if no entry price
• First Traded: full date with year from first mint timestamp
• Adds formatCompact helper and firstTraded field to PortfolioHolding

Fixes #756

Test plan

• 4 stat boxes appear next to Moleskine book (2×2 grid)
• Value shows USD with 24h % change, no PLOT value
• Balance shows shortened format (K/M)
• PnL shows USD profit/loss with % (or "—" if no entry price)
• First Traded shows full date with year
• No inline Price/Entry/Traded labels remaining
• Mobile (375px): boxes fit cleanly
• npm run build passes

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
plotlink	Ignored		Apr 2, 2026 1:45pm

[project7-interns]

T2b APPROVE

Good restructure from inline stats to 2×2 grid. Review notes:

• formatCompact helper is clean and handles edge cases (M/K/raw)
• reserveDecimals correctly used for value formatting; token balance uses hardcoded 18 (pre-existing pattern)
• PnL calculation logic is correct: (current - entry) * balance * plotUsd with proper fallback to "—"
• firstTraded efficiently reuses the existing firstMint query
• Grid layout with grid-cols-2 gap-2 should work well at 375px

No concerns.

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The new 2x2 holdings grid is close, but two parts of the implementation do not match the requested behavior for issue #756.

Findings

• [medium] The new Value box still falls back to a PLOT-denominated string when plotUsd is unavailable, even though the ticket explicitly requires USD-only display for this field.
  • File: src/app/profile/[address]/page.tsx:1513
  • Suggestion: Render — or a loading placeholder until plotUsd is available instead of falling back to ${formatPrice(...)} ${RESERVE_LABEL}.
• [medium] First Traded is currently derived from the user's first mint only, so readers who first acquired a token via a non-mint trade will incorrectly see — even when they do have trade history.
  • File: src/app/profile/[address]/page.tsx:1307
  • Suggestion: Query the earliest trade for that user/storyline without restricting to event_type = "mint"; keep the entry-price logic separate if it still needs first-mint semantics.

Decision

Requesting changes because the current implementation can show the wrong Value format and can leave First Traded blank for valid reader holdings.

[project7-interns]

Verdict: APPROVE

Summary

The follow-up commit addresses both review findings: the Value box no longer falls back to a PLOT-denominated display, and First Traded now comes from the earliest trade regardless of event type.

Findings

• None.

Decision

Approving because the Reader holdings 2x2 grid now matches the requested issue #756 behavior and the previously reported correctness gaps are resolved.