[#763] Fix plot count +1: deduplicate and add unique constraint

lib/reconcile.ts

@@ -6,6 +6,8 @@ type SupabaseDB = SupabaseClient<Database>;
 /**
  * Reconcile a storyline's plot_count and last_plot_time from the plots table.
  * Uses COUNT(*) and MAX(block_timestamp) — idempotent and safe for replays.
+ * Relies on the unique constraint on (storyline_id, plot_index) to prevent
+ * duplicate rows that would inflate the count.
  *
  * Throws on any Supabase error so callers can handle failures.
  */

src/app/api/cron/backfill/route.ts

@@ -302,7 +302,7 @@ async function processStorylineCreated(
   };
   const { error: plotError } = await supabase
     .from("plots")
-    .upsert(plotRow, { onConflict: "tx_hash,log_index" });
+    .upsert(plotRow, { onConflict: "storyline_id,plot_index", ignoreDuplicates: true });
   if (plotError) {
     throw new Error(`Database error (genesis plot): ${plotError.message}`);
   }
@@ -360,7 +360,7 @@ async function processPlotChained(
 
   const { error: plotError } = await supabase
     .from("plots")
-    .upsert(row, { onConflict: "tx_hash,log_index" });
+    .upsert(row, { onConflict: "storyline_id,plot_index" });
   if (plotError) {
     throw new Error(`Database error (plot): ${plotError.message}`);
   }

src/app/api/index/plot/route.ts

@@ -1,6 +1,6 @@
 import { NextResponse } from "next/server";
 import { type Hex, decodeEventLog, encodeEventTopics } from "viem";
 import { publicClient, getReceiptWithRetry } from "../../../../../lib/rpc";
 import { createServerClient } from "../../../../../lib/supabase";
 import { validateRecentTx } from "../../../../../lib/index-auth";
 import {
@@ -129,7 +129,7 @@
 
   const { error: dbError } = await supabase.from("plots").upsert(
     row,
-    { onConflict: "tx_hash,log_index" }
+    { onConflict: "storyline_id,plot_index" }
   );
 
   if (dbError) {

src/app/api/index/storyline/route.ts

@@ -1,6 +1,6 @@
 import { NextResponse } from "next/server";
 import { type Hex, decodeEventLog, encodeEventTopics } from "viem";
 import { publicClient, getReceiptWithRetry } from "../../../../../lib/rpc";
 import { createServerClient } from "../../../../../lib/supabase";
 import { validateRecentTx } from "../../../../../lib/index-auth";
 import {
@@ -173,7 +173,7 @@
 
   const { error: plotDbError } = await supabase.from("plots").upsert(
     plotRow,
-    { onConflict: "tx_hash,log_index" }
+    { onConflict: "storyline_id,plot_index", ignoreDuplicates: true }
   );
 
   if (plotDbError) {

supabase/migrations/00030_dedupe_plots_unique_constraint.sql

@@ -0,0 +1,33 @@
+-- Deduplicate plots rows with the same (storyline_id, plot_index), preferring
+-- the row with the richest data (non-null title first, then latest id as tiebreaker).
+-- Then add a unique constraint to prevent recurrence.
+-- Finally re-reconcile plot_count from the deduplicated data.
+
+-- Step 1: For each (storyline_id, plot_index) group, keep the best row:
+-- prefer rows with a non-empty title, then the latest id as tiebreaker.
+DELETE FROM plots
+WHERE id NOT IN (
+  SELECT DISTINCT ON (storyline_id, plot_index) id
+  FROM plots
+  ORDER BY storyline_id, plot_index,
+    (COALESCE(title, '') != '') DESC,
+    id DESC
+);
+
+-- Step 2: Add unique constraint to prevent future duplicates
+ALTER TABLE plots
+  ADD CONSTRAINT plots_storyline_plot_unique UNIQUE (storyline_id, plot_index);
+
+-- Step 3: Re-reconcile plot_count and last_plot_time from deduplicated data
+UPDATE storylines s
+SET plot_count = sub.cnt,
+    last_plot_time = sub.latest
+FROM (
+  SELECT storyline_id,
+         COUNT(*) AS cnt,
+         MAX(block_timestamp) AS latest
+  FROM plots
+  GROUP BY storyline_id
+) sub
+WHERE s.storyline_id = sub.storyline_id
+  AND (s.plot_count IS DISTINCT FROM sub.cnt OR s.last_plot_time IS DISTINCT FROM sub.latest);