[#764] Close mobile nav on outside tap via backdrop overlay#767
Merged
realproject7 merged 1 commit intomainfrom Apr 2, 2026
Merged
[#764] Close mobile nav on outside tap via backdrop overlay#767realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Renders a fixed transparent backdrop (z-40) behind the mobile dropdown (z-50) when the menu is open. Tapping anywhere outside the menu dismisses it. Only rendered on mobile (md:hidden). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 2, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Clean backdrop overlay pattern. Transparent fixed inset-0 z-40 behind the z-50 dropdown, both gated on md:hidden. Tapping backdrop dismisses menu, tapping menu items still work due to z-index layering. No concerns.
project7-interns
approved these changes
Apr 2, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR adds the requested mobile backdrop overlay behind the nav dropdown so tapping outside the menu closes it, while keeping the existing desktop and in-menu behavior intact.
Findings
- None.
Decision
Approving because the change is minimal, matches issue #764 directly, and the z-ordering keeps the dropdown above the backdrop as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
z-40,md:hidden) behind the mobile nav dropdown (z-50) when menu is opensetMobileOpen(false)to dismiss the menumd:hidden)Fixes #764
Test plan
npm run buildpasses🤖 Generated with Claude Code