Fix DeadlineCountdown style mismatch in stat boxes#811
Merged
realproject7 merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
Add valueClassName prop to DeadlineCountdown. When provided, overrides the default text-accent font-medium styling. Stat box passes text-foreground text-sm font-bold to match Market Cap and Supply boxes. Expired state preserves text-error. No change to other DeadlineCountdown usages (storyline cards, etc). Fixes #809 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the stat-box styling mismatch by letting the storyline header override DeadlineCountdown's value styling without changing its other call sites. I did not find a code-level blocker in the updated render path.
Findings
- No blocking findings.
Decision
Approving. The deadline stat box can now match the Market Cap and Supply Minted boxes while keeping the expired state in error styling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valueClassNameprop toDeadlineCountdownthat overrides the defaulttext-accent font-mediumstylingtext-foreground text-sm font-boldto match Market Cap and Supply Minted boxestext-errorcolorBefore/After
text-xs text-accent font-medium(mismatched)text-sm font-bold text-foreground(matches other stat boxes)Test Plan
Fixes #809
🤖 Generated with Claude Code