Hide DeadlineCountdown for storylines without deadlines#814
Merged
realproject7 merged 1 commit intomainfrom Apr 3, 2026
Merged
Hide DeadlineCountdown for storylines without deadlines#814realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Add has_deadline guard before rendering DeadlineCountdown in both storyline page stat box and profile page storyline card. Storylines with has_deadline=false no longer show a misleading countdown timer. Fixes #812 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 3, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR applies the missing has_deadline guard in both countdown render paths and stays tightly scoped to issue #812. I did not find a code-level blocker in the change.
Findings
- No blocking findings.
Decision
Approving. Storylines without deadlines will no longer show a misleading countdown on the storyline page or profile page, while deadline-enabled and sunset storylines keep their existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_deadlineguard before renderingDeadlineCountdownin both locationsstoryline.has_deadline && storyline.last_plot_timestoryline.has_deadline && storyline.last_plot_timeTest Plan
has_deadline=false: no countdown shown, stat box shows "—"has_deadline=true: countdown shown as beforeFixes #812
🤖 Generated with Claude Code