[#895] Show "Open" for stories without deadlines#897
Merged
realproject7 merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
Separate the deadline stat box fallback into two cases: - has_deadline=false → "Open" (intentional, no deadline set) - has_deadline=true but missing last_plot_time → "—" (data gap) Fixes #895 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Apr 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The change is minimal and matches the issue acceptance criteria. Open-ended stories now show a clear Open label while the existing deadline and sunset branches remain intact.
Findings
- No blocking findings.
Decision
Approving because the fallback branch is now correctly split between has_deadline=false and the rare missing-data case, with no evident regression in the surrounding logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_deadline=falseinstead of ambiguous "—"has_deadline=truebut missinglast_plot_timestill show "—" (rare data gap)Files Changed
src/app/story/[storylineId]/page.tsx— split fallback branch into two casespackage.json— patch bump 0.1.25 → 0.1.26Test plan
has_deadline=false(e.g. The Holloway Manuscript [P6-4] SDK — @plotlink/sdk #35) — verify "Open" labelFixes #895
🤖 Generated with Claude Code