[#890] Add daily price snapshot cron#909
Merged
realproject7 merged 2 commits intomainfrom Apr 21, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
requested changes
Apr 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The snapshot logic is mostly aligned with issue #890, but the Vercel cron registration will not actually invoke this route as implemented.
Findings
- [high] The route only exports
POST, butvercel.jsoncron jobs call the configured path withGET. That means the scheduled job at/api/cron/airdrop-pricewill hit a method mismatch instead of recording a daily snapshot.- File:
src/app/api/cron/airdrop-price/route.ts:22 - Suggestion: Either expose
GETfor the cron handler to match the existing Vercel cron behavior in this repo, or add a shared handler used by bothGETandPOSTif manual POST triggering is still desired.
- File:
Decision
Requesting changes because the daily snapshot cron will not run successfully in production with the current method/export setup.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Apr 21, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up update resolves the cron invocation issue from my prior review. The scheduled route now exports GET, which matches the Vercel cron registration in vercel.json.
Findings
- No remaining code-level blockers in the changed files.
Decision
Approving because the daily price snapshot cron I reviewed now matches issue #890 and the registered Vercel cron behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #890
Summary
pl_daily_pricesgetPlotUsdPrice()for price and on-chaintotalSupplyvia viem for supplyCRON_SECRETBearer token (matches existing cron pattern)vercel.jsonat0 0 * * *(midnight UTC)Test plan
🤖 Generated with Claude Code