[#948] Fix FDV mismatch and chart projection/mobile#951
Conversation
- Prefer Mint Club SDK (on-chain) over Promise.any race for consistent FDV - Linear projection now starts from campaign start date, not current date - Replace unreadable SVG chart on mobile with simplified milestone progress view Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Re2 Review: ✅ APPROVEAll three fixes from #948 look correct. 1. FDV price source (lib/usd-price.ts): Mint Club SDK is now tried first (sequential), with GeckoTerminal/CoinGecko as 2. Chart projection (CampaignHero.tsx): Projection line now correctly starts from campaign start ( 3. Mobile view: SVG replaced with a readable milestone progress view on <640px — progress bar, tier list, and linear target today. Uses existing design tokens ( CI: lint + typecheck green, e2e pending, Vercel preview skipped (expected). |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
This is close, but two parts of issue #948 are still not correct in the current patch. The mobile milestone view now shows incorrect percentages, and the current-FDV dot logic is unchanged from main, so the reported dot-position bug is not actually fixed.
Findings
-
[medium] Mobile milestone percentages are derived from
t.fdv / diamondFdvinstead of the configured milestone percentage from the API.- File:
src/components/airdrop/CampaignHero.tsx:524 - Suggestion: Use
t.pcthere so Bronze/Silver/Gold/Diamond reflect the milestone percentages configured by the backend (the issue example is 10/30/50/100), not 1/10/50/100 based on FDV thresholds.
- File:
-
[medium] The current FDV dot positioning bug is still unresolved.
- File:
src/components/airdrop/CampaignHero.tsx:296 - Suggestion:
dotYstill uses the exact samefdvToY(currentFdv > 0 ? currentFdv : 100, fdvLogMax)calculation asmain, so this patch does not change the behavior that issue #948 called out. Please fix the actual mapping or data fed into it and verify the dot lands at the correct Y position.
- File:
Decision
Requesting changes because the PR does not fully meet the acceptance criteria for issue #948 yet.
- Use configured t.pct for milestone percentages instead of deriving from fdv/diamondFdv - Clamp fdvToY output to [0,1] range to prevent dot rendering outside chart bounds Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up commit resolves the issues from my prior review. The mobile milestone list now uses the configured milestone percentages, and the chart changes now align with the intended FDV source and projection behavior for issue #948.
Findings
- No blocking findings.
Decision
Approving because the requested fixes are in place and the PR checks are passing.
Summary
Fixes #948
getPlotUsdPrice()now prefers Mint Club SDK (on-chain read, same source as /token page) instead ofPromise.any()racing all three sources. API aggregators are fallback-only.Patch version bump: 0.1.42 → 0.1.43
Test plan
🤖 Generated with Claude Code