Skip to content

[#978] Remove active-first sort from MCap#980

Merged
realproject7 merged 1 commit intomainfrom
task/978-active-first-trending-only
Apr 24, 2026
Merged

[#978] Remove active-first sort from MCap#980
realproject7 merged 1 commit intomainfrom
task/978-active-first-trending-only

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Removes active-first sorting from getMcapStorylines() — now pure MCap descending
  • Trending sort keeps active-first (correct per spec)
  • Recent sort was already pure chronological (no change needed)

Fixes #978

Test plan

  • MCap sort: stories ordered by market cap regardless of active status
  • Trending sort: active stories still appear first
  • Recent sort: unchanged, pure chronological

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 24, 2026 1:01am

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR matches issue #978 directly by removing active-first bias from Market Cap sorting while leaving Trending behavior intact. Recent was already pure chronological, so no extra change was needed there.

Findings

  • No blocking findings.

Decision

Approving because the patch cleanly implements the requested sorting change for MCap and aligns with the issue's acceptance criteria. Checks were still pending at review time.

@realproject7 realproject7 merged commit d49fd4f into main Apr 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Active-first sort applies to MCap and Recent — should only be on Trending

2 participants