Skip to content

Add Code for Web Scraping Video Course #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martin-martin merged 1 commit into from
Jul 7, 2020
Merged

Add Code for Web Scraping Video Course #133

martin-martin merged 1 commit into from
Jul 7, 2020

Conversation

@martin-martin
Copy link
Contributor

@martin-martin martin-martin commented Jul 7, 2020

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

@martin-martin martin-martin requested a review from dbader July 7, 2020 13:06
@martin-martin martin-martin changed the title Initial Add Code for Web Scraping Video Course Jul 7, 2020
@martin-martin martin-martin requested review from digiglean and removed request for dbader July 7, 2020 13:10
@dbader dbader self-requested a review July 7, 2020 13:40
dbader
dbader approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@dbader dbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, looks good @martin-martin. LGTM

@martin-martin martin-martin merged commit ec3a4cf into master Jul 7, 2020
@martin-martin martin-martin deleted the webscraping_course branch July 7, 2020 17:56
MiscStuff839 pushed a commit to MiscStuff839/materials that referenced this pull request Nov 16, 2025
@martin-martin
Merge pull request realpython#133 from realpython/webscraping_course
bace38d 
Add Code for Web Scraping Video Course
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbader dbader dbader approved these changes

@digiglean digiglean Awaiting requested review from digiglean

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martin-martin @dbader