Skip to content

Update README.md #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jablonskidev merged 1 commit into from
Jul 13, 2020
Merged

Update README.md #136

jablonskidev merged 1 commit into from
Jul 13, 2020

Conversation

@jablonskidev
Copy link
Contributor

@jablonskidev jablonskidev commented Jul 13, 2020

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

@jablonskidev jablonskidev requested a review from somacdivad July 13, 2020 17:45
somacdivad
somacdivad approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@somacdivad somacdivad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jablonskidev URL looks good 👍

@arvkevi was wondering if we needed to change the base folder name to better match the article title. I didn't think it was that big of a deal, but what do you think?

@jablonskidev jablonskidev merged commit e2f6bf8 into master Jul 13, 2020
@jablonskidev jablonskidev deleted the jablonskidev-patch-1 branch July 13, 2020 17:51
MiscStuff839 pushed a commit to MiscStuff839/materials that referenced this pull request Nov 16, 2025
@jablonskidev
Merge pull request realpython#136 from realpython/jablonskidev-patch-1
bccbd36 
Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@somacdivad somacdivad somacdivad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jablonskidev @somacdivad