Skip to content

Conversation

@iansedano
Copy link
Contributor

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

# Extract tokens for the given doc
print([token.text for token in introduction_doc])


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iansedano, I see that throughout the file, there are quite a few instances of two consecutive newlines. Is this intentional, or should they be reduced to one line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I've reduced all the ones I've spotted. Though the ones before and after function definitions should stay as 2 newlines.

@KateFinegan KateFinegan merged commit 30cde13 into master Dec 20, 2022
@KateFinegan KateFinegan deleted the spacy branch December 20, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants