Skip to content

Jima/threading fixup #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbader merged 2 commits into from
Mar 25, 2019
Merged

Jima/threading fixup #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63e7ae
Changed jython URL to use https to avoid redirect
jima80525 Mar 20, 2019
5c89452
Use object() for sentinel value in threading article
jima80525 Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion concurrency-overview/io_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async def download_all_sites(sites):

if __name__ == "__main__":
sites = [
"http://www.jython.org",
"https://www.jython.org",
"http://olympus.realpython.org/dice",
] * 80
start_time = time.time()
Expand Down
2 changes: 1 addition & 1 deletion concurrency-overview/io_mp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def download_all_sites(sites):

if __name__ == "__main__":
sites = [
"http://www.jython.org",
"https://www.jython.org",
"http://olympus.realpython.org/dice",
] * 80
start_time = time.time()
Expand Down
2 changes: 1 addition & 1 deletion concurrency-overview/io_non_concurrent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def download_all_sites(sites):

if __name__ == "__main__":
sites = [
"http://www.jython.org",
"https://www.jython.org",
"http://olympus.realpython.org/dice",
] * 80
start_time = time.time()
Expand Down
2 changes: 1 addition & 1 deletion concurrency-overview/io_threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def download_all_sites(sites):

if __name__ == "__main__":
sites = [
"http://www.jython.org",
"https://www.jython.org",
"http://olympus.realpython.org/dice",
] * 80
start_time = time.time()
Expand Down
6 changes: 3 additions & 3 deletions intro-to-threading/prodcom_lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import random
import threading

SENTINEL = -1
SENTINEL = object()


class Pipeline:
Expand Down Expand Up @@ -51,9 +51,9 @@ def producer(pipeline):
def consumer(pipeline):
""" Pretend we're saving a number in the database. """
message = 0
while message != SENTINEL:
while message is not SENTINEL:
message = pipeline.get_message("Consumer")
if message != SENTINEL:
if message is not SENTINEL:
logging.info("Consumer storing message: %s", message)


Expand Down