Skip to content

Sample code for the article on basic types#522

Merged
brendaweles merged 7 commits intomasterfrom
python-data-types
Apr 28, 2024
Merged

Sample code for the article on basic types#522
brendaweles merged 7 commits intomasterfrom
python-data-types

Conversation

@lpozo
Copy link
Copy Markdown
Contributor

@lpozo lpozo commented Apr 11, 2024

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Copy link
Copy Markdown
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, thanks!

Comment thread python-basic-data-types/point.py Outdated
Comment on lines +12 to +15
origin = Point(0, 0)
bool(origin)
point = Point(2, 4)
bool(point)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to make this executable with some output, either like this:

Suggested change
origin = Point(0, 0)
bool(origin)
point = Point(2, 4)
bool(point)
origin = Point(0, 0)
print(bool(origin))
point = Point(2, 4)
print(bool(point))

Or, potentially wrap it into the name-main idiom, but maybe no need for that for this.

Comment thread python-basic-data-types/escape_seqs.py
Copy link
Copy Markdown
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@brendaweles brendaweles merged commit cd2d65e into master Apr 28, 2024
@brendaweles brendaweles deleted the python-data-types branch April 28, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants