Give credits #343
Give credits #343
Conversation
docs/conf.py
Outdated
There was a problem hiding this comment.
How about "and contributors" instead?
There was a problem hiding this comment.
👍 for "and contributors"
|
@techtonik did you sign the CLA? Just kidding |
|
@sigmavirus24, no, passed Most Valuable Patent Troll certification instead. ;) |
|
Love this! But, let's find another place for this. "A Kenneth Reitz Project" is a special phrase I put at the bottom of all my projects :) |
|
Well, makes sense to leave only bus factor subjects there. =) |
|
@techtonik can you come up with an alternate wording for this to satisfy @kennethreitz that'd be awesome. I'd love to merge this. |
|
@kennethreitz, I restored the special phrase. Is that ok? =) |
|
@kennethreitz this preserves your "A Kenneth Reitz project" and adds the credit given to contributors. I'm 👍, can you give it one last once over? |
|
You guys have no eye for aesthetic :) Let's put a link in the sidebar. |
|
Damnit Jim I'm a programmer not a designer! (Self-portrait for reference: |
|
Replace the entire Feedback section with Contributors, including a rough estimation of the number of people who have sent pull requests :) |
|
This will require fetching and parsing https://api.github.com/repos/kennethreitz/python-guide/stats/contributors on each request, so unless some HTML5 guru jumps in to help with caching info to local storage based on last guide hash, I don't really see the way how to keep that updated. http://developer.github.com/v3/repos/statistics/ It is also possible that we will hit Github rate limits on API calls too soon http://developer.github.com/v3/#rate-limiting |
|
No, just plain text. KISS. |
|
Plain text list should still be updated somehow, so there should be script or somethings that produces this plain text. The Github API can not be used, because it returns only 100 contributors out of current 135. Any ideas how to get the list with plain Git? |
|
No, just plain text. KISS. |
|
But just the block with some info about contributors and link to Github statistics page is boring. The short version of Github hi-score in the blank space of the sidebar would be more fun. |
|
This is a carefully curated guide, that is comprised of text, not JavaScript. Documentation is sacred, please respect it ;) |
|
tl;dr Working on improving the patch. Stay tuned. |
|
Opened a clean pull request for that. |
5 participants
This may encourage more Python folks to send edits.