Skip to content

Conversation

@kurtdoherty
Copy link
Contributor

Context

  • Menu.Divider was originally implemented as a <hr> specific to menus, but this was not meant to be the case.
  • There are other use-cases that require a divider that we currently have no generic component for.

This PR

  • Effectively renames Menu.Divider to Divider.

note: Menu.Divider is still available for convenience, but is just a re-export of the generic Divider component.
note: The el-menu-divider class is has been removed as a result of the rename.

Screenshot 2025-08-25 at 11 43 39 am

@rpt-uk-github
Copy link

rpt-uk-github commented Aug 25, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty marked this pull request as ready for review August 25, 2025 01:48
@kurtdoherty kurtdoherty force-pushed the feat-add-generic-divider branch 2 times, most recently from 5660199 to 511226f Compare August 25, 2025 02:06
@kurtdoherty kurtdoherty force-pushed the feat-add-generic-divider branch from 511226f to c3376f4 Compare August 25, 2025 02:11
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 90d624d1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (90d624d) Report Missing Report Missing Report Missing
Head commit (c3376f4) 8305 7669 92.34%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#711) 7 7 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty merged commit b9446c5 into main Aug 25, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the feat-add-generic-divider branch August 25, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants