-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add new TableRowPrimaryAction
#715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
| text-decoration: none; | ||
|
|
||
| outline: none; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this is the special sauce for the primary action. It's not a fool-proof approach, but it's cheap and will get us moving forward with good a11y and DOM structure.
In particular, it's susceptible to intermediate elements provided by consumers that use relative positioning. Hopefully, this will not prove to be a significant issue, but if it does and we need to work around it, we'll likely reach for anchor positioning (i.e. using CSS anchor positioning to position the ::after pseudo-element w.r.t. to the row as an anchor.
| border: none; | ||
| margin: 0; | ||
| padding: 0; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: the default font style is the "primary" styled outlined in the design spec. Since this component is for the "primary" action of the row, it should always be used in the row header cell, which is mean to use the medium weight font.
Context
@reapit/elements/lab/table, but these don't facilitate the level of nuance required by the DS. For example:td,trand so on, but we may need the flexibility of using them in a div-based DOM structure instead.@reapit/elements/core/table.This PR
TableRowPrimaryActionandTableRowPrimaryActionButton.note: These components render as an anchor and button respectively, but ones whose "hit area" will expand to fill the bounding box of the closest, relatively-positioned ancestor, which, by default, will be the table row.