Skip to content

Conversation

@tyler27
Copy link
Contributor

@tyler27 tyler27 commented Mar 5, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features) - Not required, doesn't need to be a hardcoded number.
  • Docs have been added / updated (for bug fixes / features) - Docs not required for this.

PR Type

What kind of change does this PR introduce?
One liner change to fix hard-coding of radius for CircularLayoutInputs

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

You have to create your own interface for it that takes in a number and extends LayoutFactoryProps, but it would be nice to not have to duplicate these interfaces, since it's already defined with your library.

Issue Number: N/A

What is the new behavior?

Switching hard-coded radius to use a type of number.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Again, if this is designed intentionally this way - please let me know; it just doesn't seem right.

* Radius of the circle.
*/
radius: 300;
radius: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#facepalm - thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course :)

@netlify
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit 4065a73
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/67c88c2d51a25b000893e104
😎 Deploy Preview https://deploy-preview-311--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit 31cadae into reaviz:master Mar 5, 2025
4 of 5 checks passed
@tyler27 tyler27 deleted the bugfix/hardcoded-radius branch March 5, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants