Skip to content

Conversation

@SerhiiTsybulskyi
Copy link
Contributor

@SerhiiTsybulskyi SerhiiTsybulskyi commented Apr 14, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

hotkeys not working

Issue Number: N/A

What is the new behavior?

update reakeys and added keydown action type to get work hotkeys

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screen.Recording.2025-04-14.at.16.42.54.mov

@SerhiiTsybulskyi SerhiiTsybulskyi self-assigned this Apr 14, 2025
@netlify
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit 3a62c68
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/67fd11d5d819f400083b309e
😎 Deploy Preview https://deploy-preview-317--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

category: 'Graph',
keys: 'command+shift+i',
keys: 'mod+shift+i',
action: 'keydown',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add the action?

Copy link
Contributor Author

@SerhiiTsybulskyi SerhiiTsybulskyi Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default action is keypress, and that isn't working in that case (KeyPress doesn't contain modifier info), also keypress does not work when hotkey is already bonded by the system

@amcdnl amcdnl merged commit 3ec3d2d into master Apr 14, 2025
5 checks passed
@amcdnl amcdnl deleted the fix-hotkeys branch April 14, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants