Skip to content

Fixed #145 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 1, 2018
Merged

Fixed #145 #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6601e5c
Added "non_relation_field" to types with documentation
roelofjan-elsinga Oct 8, 2018
0345f86
Changed "non_relation_field" to "is_relation"
roelofjan-elsinga Oct 9, 2018
3f88d11
Update SelectFields.php
Oct 10, 2018
0d13306
Merged upstream into master
roelofjan-elsinga Nov 1, 2018
a74d749
Fixed #145, changed to ->config
roelofjan-elsinga Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/advanced.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,6 @@ class UserType extends GraphQLType
public function fields()
{
return [

// ...

// JSON column containing all posts made by this user
Expand All @@ -935,6 +934,5 @@ class UserType extends GraphQLType
}

// ...

}
```
2 changes: 1 addition & 1 deletion src/Rebing/GraphQL/Support/SelectFields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ protected static function handleFields(array $requestedFields, $parentType, arra
$customQuery = array_get($fieldObject->config, 'query');

// Check if the field is a relation that needs to be requested from the DB
$queryable = self::isQueryable($fieldObject);
$queryable = self::isQueryable($fieldObject->config);

// Pagination
if(is_a($parentType, PaginationType::class))
Expand Down