This repository was archived by the owner on Mar 2, 2026. It is now read-only.
Add non immediate flag to cb event provider for graph compatibility#393
Merged
reble merged 1 commit intopablo/graph-native-recording-prototype-v2from Jan 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at level-zero tests, counter based events with graphs always set
ZEX_COUNTER_BASED_EVENT_FLAG_NON_IMMEDIATEeven though we record over an immediate command list. This seems to be a requirement to use counter based events with graphs. Adding this fixes my reproducers andenable_native_recording.cppin this branch.This flag is compatible with
ZEX_COUNTER_BASED_EVENT_FLAG_IMMEDIATE, so we may want to directly upstream this change once checking it has no downsides.There is also a
ZEX_COUNTER_BASED_EVENT_FLAG_EXTERNALflag that may also be needed for external synchronization.