Conversation
fe4fd73 to
850b319
Compare
|
All right! Thanks for doing this. I patched it in to make sure it runs the tests. Wow, I'm still on Python 3.7 for this project, I can update it! The first commit is unassuming and fine. I now write (from reading the The second is... horrifying :-D :-D but does fix the issue at hand and seems to be the only possible solution given static type checking. mypy still doesn't pass for various other reasons but I'll deal with those! Thanks again, I'm pulling this as-is. |
|
I just released this as dtyper 2.2.0, let me know how it works out! I am following an idea with the |
|
thanks! Don't forget to create the tag + GitHub release for 2.2.0 as well 😉 |
|
Done, I actually obsoleted Python 3.7 in a later commit so it's 2.3.1 now. |
not as fancy as the dynamic construction of
__all__but Pyright was complaining that the members aren't exported and this is not supported for dunder attributesalso wasn't able to get completion results for the
@app.commanddecorator, so I expanded the*args, **kwargsin the signature