Skip to content

Conversation

@joewagner
Copy link
Contributor

@joewagner joewagner commented Apr 2, 2025

The changes in #582 moved the AccountInfo type from the fendermint_blobs_shared packages to the fendermint_blobs package. This type is needed by the rust SDK, and the move made the type private.
The change in this PR makes the fendermint_blobs::state module public, so the SDK can access it.
Related PR for the SDK is here: recallnet/rust-recall#256

@joewagner joewagner requested review from sanderpick and ukstv April 2, 2025 16:57
@joewagner joewagner marked this pull request as ready for review April 2, 2025 16:58
Copy link
Contributor

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible to just move it back to shared? or we can fix later

@joewagner
Copy link
Contributor Author

cc: @sam701

@joewagner
Copy link
Contributor Author

joewagner commented Apr 2, 2025

possible to just move it back to shared? or we can fix later

For sure. I almost did that, but wasn't sure if there was a reason it got moved.

@joewagner
Copy link
Contributor Author

@sanderpick I moved the type back to shared, assuming CI passes, this makes the SDK work without any changes, so recallnet/rust-recall#256 can be closed.
Does this look good?

@joewagner joewagner requested a review from sanderpick April 2, 2025 17:54
@sanderpick
Copy link
Contributor

looks good to me but @ukstv what do you think? not sure if you had a reason for the move

@ukstv
Copy link
Contributor

ukstv commented Apr 2, 2025

Started writing this: "The reason for the move was that it uses to_delegated_address of the recall_actor_sdk which supposedly should work only inside a WASM actor. That might lead to a problem later, because of...." And then I realized it does not make any sense. So LGTM.

The original reason was somehow related to to_delegated_address fn, but I do not recall what was that.

@joewagner joewagner merged commit dc4da8c into main Apr 2, 2025
13 checks passed
@joewagner joewagner deleted the joe/fix-types branch April 2, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants