Skip to content

feat(UI): Show Episode Runtime #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LagradOst merged 4 commits into from
Jul 25, 2024
Merged

feat(UI): Show Episode Runtime #1207

LagradOst merged 4 commits into from
Jul 25, 2024

Conversation

@KingLucius
Copy link
Contributor

@KingLucius KingLucius commented Jul 22, 2024

No description provided.

fire-light42
fire-light42 reviewed Jul 22, 2024
View reviewed changes
@KingLucius KingLucius requested a review from fire-light42 July 23, 2024 10:46
fire-light42
fire-light42 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged anytime, but MainAPI changes might need to be postponed until stable release.

@KingLucius
Copy link
Contributor Author

KingLucius commented Jul 25, 2024

This can be merged anytime, but MainAPI changes might need to be postponed until stable release.

There is a backwards compatibility constructor for that

@Luna712
Copy link
Contributor

Luna712 commented Jul 25, 2024

This can be merged anytime, but MainAPI changes might need to be postponed until stable release.

There is a backwards compatibility constructor for that

@KingLucius

AFAIK that only works for some extensions when there is a stable release as has happened with my last content rating PR which also had a backwards compatible constructor.

@Luna712
Copy link
Contributor

Luna712 commented Jul 25, 2024

Otherwise extensions become incompatible on stable

@KingLucius
Copy link
Contributor Author

KingLucius commented Jul 25, 2024 •
edited
Loading

This can be merged anytime, but MainAPI changes might need to be postponed until stable release.

There is a backwards compatibility constructor for that

@KingLucius

AFAIK that only works for some extensions when there is a stable release as has happened with my last content rating PR which also had a backwards compatible constructor.

That needs more testing to check what is the issue
Anyway we are not in hurry, we can wait no issue

@LagradOst LagradOst merged commit e3ff1cf into recloudstream:master Jul 25, 2024
@KingLucius KingLucius deleted the episodeRuntime branch August 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fire-light42 fire-light42 fire-light42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KingLucius @Luna712 @fire-light42 @LagradOst