Skip to content

Conversation

@Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Feb 11, 2025

There are multiple scenarios where the previous approach fails at the moment:

  1. When the extension uses JSON data to as dataUrl, handleIntentData tries to match the JSON data to the main url of the engine, which obviously won't work because the JSON data isn't prefixed with the mainUrl
  2. If the mainUrl is different to the used dataUrl for the series (e.g. because the mainUrl is the HTML url for the extension, but the internally used urls refer to the api url for the extension), there's no match
  3. There are various multi-providers that accumulate stream sources from different sites but use TMDB internally to reference series (i.e. their TMDB URL). However, such providers either don't provide any mainUrl, and if they do, it's not guaranteed that the user will land on the right extension when clicking the link, because multiple providers possible use the same mainUrl.

The idea in this PR is to use the api name in order to identify the origin of the notifications dataUrl, so that the right api can be found (by its name).

@Bnyro Bnyro force-pushed the fix-subscription-notifications-intent branch from 321fe40 to d2e205b Compare February 11, 2025 10:28
Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@fire-light42 fire-light42 merged commit 12626cc into recloudstream:master Feb 11, 2025
2 checks passed
@Bnyro Bnyro deleted the fix-subscription-notifications-intent branch February 11, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants