Added new class Score#1748
Merged
fire-light42 merged 1 commit intomasterfrom Jul 19, 2025
Merged
Conversation
Contributor
|
Totally agree 👍 |
Collaborator
Author
I guess, but only by a negligible amount. This pull request is mostly to make it easier for first time extension developers to make sense of the scoring system, and make it easier to write for long time extension developers. |
Contributor
|
I absolutely agree with this as well. |
Contributor
|
It's pretty good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primary inspired by #1745 as CloudStream currently has several different ways of storing score, 0-10000, 0-100 and 0-10. This seeks to unify them into a single primitive that is easier to use.
The new syntax would be
score = Score.from10("7.5")orscore = Score.from5(4.1)orscore = Score.from100(84)oraddScore("7.5")instead ofrating = text?.toFloat()?.times(1000)?.toInt()As this is primarily to make the API easier, what do some of you extension developers think of this @phisher98 @Luna712 @Sarlay @KingLucius ?
Anyone, comment if you have any input on this.