-
Notifications
You must be signed in to change notification settings - Fork 765
Fix scroll issue on bottom dialogs and add drag handle to UI #2333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Technically, the only fix necessary was setting `isNestedScrollingEnabled = true` on the ListView in order to make it properly scrollable and not dismiss when scrolling up unless at the top already, however, this also cleans up the layout a bit.
|
isNestedScrollingEnabled? Are you sure this will not devastate performance? |
Doesn't seem to when testing anyway. |
|
I think I have a better fix though |
fire-light42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked, and "isNestedScrollingEnabled" does not cause the issue I was worried about.
This method only partially works also though I have another PR I could also do separately if you want that improves both UX and UI further then this does. |
|
I will just commit to this PR and can revert if you'd rather the other method. |
Nice, I recommend using our baseadapter/nostateadapter, as listview does not recycle views ect. |
This could still use more improvement then I did now but since it doesn't use that adapter at a yet I didn't do it here, we could probably make this whole ListView some RecyclerView but wanted to minimize the amount of changes in just this bug fix, but can change it more if you want also. I was also thinking we should create a BottomSheetDialogListView that handles this and use that instead of this |
app/src/main/java/com/lagradost/cloudstream3/utils/SingleSelectionHelper.kt
Outdated
Show resolved
Hide resolved
To many accessibility issues or potential bugs the other way.
Technically, the only fix necessary was setting
isNestedScrollingEnabled = trueon the ListView in order to make it properly scrollable and not dismiss when scrolling. But this also cleans up the layout and adds a drag handler view to make it more visibly explicit.Fixes #349
Fixes #2128
Fixes #2210