Skip to content

Conversation

@Luna712
Copy link
Contributor

@Luna712 Luna712 commented Dec 14, 2025

Technically, the only fix necessary was setting isNestedScrollingEnabled = true on the ListView in order to make it properly scrollable and not dismiss when scrolling. But this also cleans up the layout and adds a drag handler view to make it more visibly explicit.

Fixes #349
Fixes #2128
Fixes #2210

Technically, the only fix necessary was setting `isNestedScrollingEnabled = true` on the ListView in order to make it properly scrollable and not dismiss when scrolling up unless at the top already, however, this also cleans up the layout a bit.
@fire-light42
Copy link
Collaborator

isNestedScrollingEnabled? Are you sure this will not devastate performance?

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 14, 2025

isNestedScrollingEnabled? Are you sure this will not devastate performance?

@fire-light42

Doesn't seem to when testing anyway.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 14, 2025

I think I have a better fix though

Copy link
Collaborator

@fire-light42 fire-light42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, and "isNestedScrollingEnabled" does not cause the issue I was worried about.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 14, 2025

I checked, and "isNestedScrollingEnabled" does not cause the issue I was worried about.

This method only partially works also though I have another PR I could also do separately if you want that improves both UX and UI further then this does.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 14, 2025

I will just commit to this PR and can revert if you'd rather the other method.

@fire-light42
Copy link
Collaborator

I checked, and "isNestedScrollingEnabled" does not cause the issue I was worried about.

This method only partially works also though I have another PR I could also do separately if you want that improves both UX and UI further then this does.

Nice, I recommend using our baseadapter/nostateadapter, as listview does not recycle views ect.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 14, 2025

I checked, and "isNestedScrollingEnabled" does not cause the issue I was worried about.

This method only partially works also though I have another PR I could also do separately if you want that improves both UX and UI further then this does.

Nice, I recommend using our baseadapter/nostateadapter, as listview does not recycle views ect.

This could still use more improvement then I did now but since it doesn't use that adapter at a yet I didn't do it here, we could probably make this whole ListView some RecyclerView but wanted to minimize the amount of changes in just this bug fix, but can change it more if you want also. I was also thinking we should create a BottomSheetDialogListView that handles this and use that instead of this setOnTouchListener but decided not to for now. Not sure exactly what you want to so though, but can change it if you want.

To many accessibility issues or potential bugs the other way.
@Luna712 Luna712 requested a review from fire-light42 December 15, 2025 21:47
@Luna712 Luna712 changed the title Fix scroll issue on bottom dialogs Fix scroll issue on bottom dialogs and add drag handle to UI Dec 17, 2025
@fire-light42 fire-light42 merged commit 729ede5 into recloudstream:master Dec 17, 2025
2 checks passed
@Luna712 Luna712 deleted the fix-bottom-scroll branch December 17, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some menus don't allow scrolling up in landscape mode on mobile Improve scrolling on through Video Source overview prompt

2 participants