Fix some bugs in DownloadedPlayerActivity#2758
Fix some bugs in DownloadedPlayerActivity#2758Luna712 wants to merge 2 commits intorecloudstream:masterfrom
Conversation
| // When savedInstanceState != null the system saved state before killing the | ||
| // backgrounded process the NavController restores the correct player fragment | ||
| // automatically. Do not replay the intent as it would push a duplicate player. | ||
| if (savedInstanceState == null) { |
There was a problem hiding this comment.
I am unable to fully test this until #2750 is fixed, as introducing a state where savedInstanceState != null causes that bug.
There was a problem hiding this comment.
I also could have done this part wrong. I was testing a lot of things in a massive local change, this 1) may depend on other things or 2) actually be totally unnecessary. Anyway #2761 fixes that bug. But that might still not let it work here. If not that part can be reverted.
There was a problem hiding this comment.
If the issue still happens with a null savedInstanceState I will revert that part. I was building this on top of change I was testing to use SavedStateHandle also, so may have had some other effect also. The other bugs this fixes are more important regardless.
2 participants
No description provided.