Refactor: Player, Generator and ViewModel#2764
Merged
fire-light42 merged 3 commits intomasterfrom May 6, 2026
Merged
Conversation
Collaborator
Author
|
@Luna712 you might want to test this pull request, it should solve most of your issues ❤️ |
Luna712
approved these changes
May 5, 2026
Collaborator
Author
|
Fixed concurrency issues in RepoLinkGenerator and currentQualityProfile cache for better UX. |
Contributor
|
@fire-light42 I think I found a major issue that seems to be related to this. It plays the wrong episode sometimes. The player said it was playing S0E1 even though it was like S20E36 or something. It happened after returning to the app after a couple hours and the player reloaded (probably process death) but previously when the player reloaded it would just load all links again on the right episode. I don't know how to reproduce exactly, but to me that indicates some potential major issue with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2761 #2750 #2751
Fixes #2746
This pull requests refactors the following:
Fixes: