Skip to content

fix: implement memory-based throttle to prevent OOM during downloads #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fire-light43 merged 2 commits into from
May 12, 2026
+26 −0
Merged

fix: implement memory-based throttle to prevent OOM during downloads #2786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
534eae2
fix: implement memory-based throttle to prevent OOM during downloads
asheeshsahu7300 May 12, 2026
82ead3f
Reduce limit to 50MB
fire-light43 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/src/main/java/com/lagradost/cloudstream3/utils/downloader/DownloadManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,10 +1161,23 @@ object VideoDownloadManager {
// this will take up the first available job and resolve
while (true) {
if (!isActive) return@launch

var isTooFarAhead = false
fileMutex.withLock {
if (metadata.type == DownloadType.IsStopped
|| metadata.type == DownloadType.IsFailed
) return@launch

// Limit RAM usage by throttling if too much data is downloaded but not yet written to disk
// 50MB limit
if (metadata.bytesDownloaded - metadata.bytesWritten > 50_000_000) {
isTooFarAhead = true
}
}

if (isTooFarAhead) {
delay(500)
continue
}

// mutex just in case, we never want this to fail due to multithreading
Expand Down Expand Up @@ -1333,10 +1346,23 @@ object VideoDownloadManager {
launch(Dispatchers.IO) {
while (true) {
if (!isActive) return@launch

var isTooFarAhead = false
fileMutex.withLock {
if (metadata.type == DownloadType.IsStopped
|| metadata.type == DownloadType.IsFailed
) return@launch

// Limit RAM usage by throttling if too much data is downloaded but not yet written to disk
// 50MB limit
if (metadata.bytesDownloaded - metadata.bytesWritten > 50_000_000) {
isTooFarAhead = true
}
}

if (isTooFarAhead) {
delay(500)
continue
}

// mutex just in case, we never want this to fail due to multithreading
Expand Down