Skip to content

fix(help-popup): keep glass smoke path terminal-safe #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagyVikt merged 1 commit into from
May 16, 2026
+8 −4
Merged

fix(help-popup): keep glass smoke path terminal-safe #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions scripts/codex-fleet/bin/help-popup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
# fleet-tui-poc displays before this PR), context-menu hotkeys are bare
# single letters, tmux bindings use the user's `prefix` (default Ctrl+B).
#
# Smoke test (standalone, exits when stdin EOFs):
# bash scripts/codex-fleet/bin/help-popup.sh < /dev/null
# Smoke test (standalone, one byte dismisses after render):
# printf q | bash scripts/codex-fleet/bin/help-popup.sh
set -eo pipefail

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
Expand Down Expand Up @@ -57,6 +57,10 @@ menu_repeat() {
done
}

clear_popup() {
clear 2>/dev/null || printf '\033[H\033[2J'
}

# ── chrome helpers (visual lineage matches pane-context-menu.sh) ───────────
draw_top() {
menu_fg "$IOS_SEPARATOR"
Expand Down Expand Up @@ -121,7 +125,7 @@ draw_header() {
}

# ── render ────────────────────────────────────────────────────────────────
clear
clear_popup
printf '\n'

draw_top
Expand Down Expand Up @@ -180,4 +184,4 @@ _ios_reset
# When stdin is /dev/null (smoke test) read returns immediately so the popup
# renders and exits cleanly without hanging.
read -rsn1 -t 60 _ || :
clear
clear_popup