Conversation
Usage-limit stop detection missed code-style reasons like RATE_LIMIT_EXCEEDED because underscore-delimited tokens bypassed word-boundary regex checks. Normalize reason strings before keyword matching so takeover handoff/blocker emits consistently for provider code payloads. Constraint: Stop reason formats vary by provider and often use uppercase underscore codes Rejected: Add one-off RATE_LIMIT_EXCEEDED regex only | leaves other underscore code variants brittle Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep reason-signal matching normalization-only; narrative-signal thresholds remain stricter to avoid false positives Tested: pnpm biome check packages/hooks/src/handlers/stop.ts packages/hooks/test/runner.test.ts Tested: pnpm --filter @colony/hooks typecheck Tested: pnpm --filter @colony/hooks test -- test/runner.test.ts Not-tested: Full @imdeadpool/colony-cli build in this worktree (workspace @colony/spec resolution baseline)
NagyVikt
deleted the
agent/codex/handle-rate-limit-exceeded-usage-limit-s-2026-04-24-20-23
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).