fix(storage): group mcp_metrics error_reasons by code only#542
Merged
NagyVikt merged 1 commit intoMay 14, 2026
Merged
Conversation
Handlers embed session IDs in error messages (e.g. "sub-task is claimed by codex-session-X"), which fragmented identical errors into many distinct (code, message) groups and pushed most past the 3-row truncation. On live data `task_plan_claim_subtask` showed 7 of 93 errors in `Top error reasons` while the Operations table showed 93. Drop `error_message` from the grouping key (SQLite's bare-column-with-MAX(ts) picks the latest sample message), bump the per-op cap 3 -> 8, and add a regression test that pins sum_of_reasons == error_count for 25 unique-message races + 2 not-found errors. After the fix the same op reports 60 + 33 + 1 = 94 across three codes, matching error_count exactly.
NagyVikt
deleted the
agent/claude/group-mcp-metric-error-reasons-by-code-o-2026-05-14-14-14
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).