Merged
Conversation
Message delivery claimed that to_session_id narrowed routing, but the inbox predicates still fell back to to_agent and read marking trusted any session with an observation id. This aligns list, pending, and read authorization around one recipient predicate and keeps task_id-scoped listing inside the caller's joined tasks. Constraint: task_message is advisory coordination state, but unread status drives turn-start attention and must not be clearable by unrelated sessions Rejected: Only patch task_messages listing | pendingMessagesFor and mark_read would still leak or clear targeted messages Confidence: high Scope-risk: narrow Tested: pnpm --filter @colony/mcp-server test -- messages.test.ts Tested: pnpm test Tested: pnpm typecheck Tested: pnpm exec biome check packages/core/src/messages.ts packages/core/src/task-thread.ts apps/mcp-server/test/messages.test.ts vitest.config.ts Not-tested: pnpm lint remains blocked by existing repo-wide Biome formatting/import diagnostics outside this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).