Skip to content

Keep directed task messages private#61

Merged
NagyVikt merged 1 commit intomainfrom
agent/codex/fix-task-message-routing-and-read-author-2026-04-25-00-19
Apr 24, 2026
Merged

Keep directed task messages private#61
NagyVikt merged 1 commit intomainfrom
agent/codex/fix-task-message-routing-and-read-author-2026-04-25-00-19

Conversation

@NagyVikt
Copy link
Copy Markdown
Collaborator

Automated by gx branch finish (PR flow).

Message delivery claimed that to_session_id narrowed routing, but the inbox predicates still fell back to to_agent and read marking trusted any session with an observation id. This aligns list, pending, and read authorization around one recipient predicate and keeps task_id-scoped listing inside the caller's joined tasks.

Constraint: task_message is advisory coordination state, but unread status drives turn-start attention and must not be clearable by unrelated sessions

Rejected: Only patch task_messages listing | pendingMessagesFor and mark_read would still leak or clear targeted messages

Confidence: high

Scope-risk: narrow

Tested: pnpm --filter @colony/mcp-server test -- messages.test.ts

Tested: pnpm test

Tested: pnpm typecheck

Tested: pnpm exec biome check packages/core/src/messages.ts packages/core/src/task-thread.ts apps/mcp-server/test/messages.test.ts vitest.config.ts

Not-tested: pnpm lint remains blocked by existing repo-wide Biome formatting/import diagnostics outside this change
@NagyVikt NagyVikt merged commit a8bab23 into main Apr 24, 2026
@NagyVikt NagyVikt deleted the agent/codex/fix-task-message-routing-and-read-author-2026-04-25-00-19 branch April 24, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant