Build agent launch commands safely#455
Merged
NagyVikt merged 1 commit intoApr 29, 2026
Merged
Conversation
Agent orchestration needs a command-construction layer that can prepare supported CLI invocations without executing them. This adds a shell-quoted launch/resume builder with registry-compatible definitions and focused coverage for supported prompt modes. Constraint: src/agents/registry.js is a dependency lane and is not present in this checkout yet, so the builder supports registry definitions while keeping fallback definitions testable. Rejected: execute commands directly from the builder | launch orchestration needs an inspectable string and must not spawn agents yet Confidence: high Scope-risk: narrow Directive: Keep this module construction-only; command execution belongs in a separate launcher path. Tested: node --test test/agents-launch.test.js; node --check src/agents/launch.js Not-tested: full npm test suite
NagyVikt
deleted the
agent/codex/agent-launch-command-construction-2026-04-29-21-23
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).