test(metadata): unblock 4 stale assertions after the budget-friendly trims#576
Merged
NagyVikt merged 1 commit intoMay 14, 2026
Conversation
…trims
The four metadata.test.js failures predated this PR — three are stale
assertions that drifted out of sync with intentional repo changes, one
is a legitimately missing release-notes entry for v7.0.43.
- Add `### v7.0.43` release-notes section covering the
budget-friendly CI templates, gx ci-init, gx budget, label-based
opt-in, and the pre-flight gate in gx branch finish.
- Loosen the cosign-installer assertion from `# v4.1.1` to `# v4.1.\d+`
so a patch bump (already present at v4.1.2) doesn't break the gate;
major/minor bumps still do.
- Split the "About copy + problem-solution visuals" test into two:
- keep enforcing the problem/solution image links in README
- retire the README->about_description.txt link assertion that
PR #564 obsoleted; package.json description must still match
about_description.txt
- Split the "CI and CodeQL workflows run on PRs" test into two:
- keep the CI-on-PR check (still required)
- replace the CodeQL-on-PR check with a schedule + workflow_dispatch
+ "no pull_request trigger" check matching the post-PR-#571 reality
Verification: `node --test test/metadata.test.js` now reports 27/27
passing (was 21/25 before this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NagyVikt
deleted the
agent/claude/fix-metadata-test-stale-assertions-2026-05-14-02-09
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the 4 long-standing
test/metadata.test.jsfailures that predated this PR. Three were stale assertions drifting away from intentional repo changes; one was a legitimately missing release-notes entry.### v7.0.43release-notes section added to README.md covering the recent budget-friendly CI templates (PR ci: budget-friendly defaults + templates for gitguardex-managed projects #571), label-based opt-in (ci: label-based opt-in for AI review + full matrix on agent PRs #573),gx budget(feat(cli): gx budget — Actions usage + paid-spend thresholds #574),gx ci-init(feat(cli): gx ci-init — scaffold budget-friendly workflows into a repo #575), and the pre-flight gate ingx branch finish(feat(branch-finish): pre-flight gate + auto-promote drafts after pass #572).# v4.1.1to# v4.1.\d+. The workflow had already moved to v4.1.2; this lets dependabot/renovate land patch bumps without breaking the gate. Major/minor bumps still trip it.[about_description.txt](./about_description.txt)link — PR Update README.md #564 deliberately removed that paragraph from README.package.json descriptionmust still matchabout_description.txtbyte-for-byte.workflow_dispatch+ "nopull_requesttrigger" check that matches the post-PR-ci: budget-friendly defaults + templates for gitguardex-managed projects #571 reality. CodeQL was the single most expensive workflow per run on this repo, and per-PR triggers were intentionally dropped as part of the budget trim.Test plan
node --test test/metadata.test.js— 27/27 passing (was 21/25 before this PR)npm testsweep — running in background; expect 0 new failures since the only files touched areREADME.mdandtest/metadata.test.js🤖 Generated with Claude Code