Skip to content

fix dual color on dark theme#1696

Merged
sanjay-kv merged 2 commits into
recodehive:mainfrom
hrx01-dev:fix/dual-color-on-darktheme
May 24, 2026
Merged

fix dual color on dark theme#1696
sanjay-kv merged 2 commits into
recodehive:mainfrom
hrx01-dev:fix/dual-color-on-darktheme

Conversation

@hrx01-dev
Copy link
Copy Markdown
Contributor

Description

Dual bluish/black dark surfaces and a merge conflict in [custom.css] caused inconsistent dark-theme surfaces on docs and blog pages.
Fixes #1676

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

normalized child-combinator spacing (e.g. [.blog-wrapper .col.col--2 > div].
Dark palette → black: replaced navy values with black-based tokens:
--dark-bg-primary, --dark-bg-secondary, --dark-bg-tertiary
--dark-card-bg, --dark-card-hover-bg
added [data-theme="dark"] overrides for surface tokens to force black surfaces:
[--ifm-background-color], [--ifm-background-surface-color], [--ifm-navbar-background-color], [--ifm-footer-background-color], [--ifm-toc-border-color], --ifm-menu-color-background-active.

Screenshot 2026-05-24 110925

Dependencies

  • None

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 24, 2026

@hrx01-dev is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions Bot added in-review The current changes are in review and would need approval and testing before merging level 1 10 points recode this is label for leaderboard labels May 24, 2026
@github-actions github-actions Bot added this to the recode:launch 3.0 milestone May 24, 2026
@github-actions github-actions Bot added Enhacement gssoc26 label gssoc:approved gssoc label type:design gssoc labels 10pts type:docs gssoc label 5pts labels May 24, 2026
@github-actions
Copy link
Copy Markdown

✅ Synchronized metadata from Issue #1676:

  • Labels: level 1, recode, Enhacement, gssoc:approved, type:docs, type:design
  • Milestone: recode:launch 3.0

@sanjay-kv
Copy link
Copy Markdown
Member

can u check the conflicts @hrx01-dev

@github-actions
Copy link
Copy Markdown

✅ Synchronized metadata from Issue #1676:

  • Labels: level 1, recode, Enhacement, gssoc:approved, type:docs, type:design
  • Milestone: recode:launch 3.0

@hrx01-dev hrx01-dev force-pushed the fix/dual-color-on-darktheme branch from 18f547c to 71d85fa Compare May 24, 2026 10:59
@github-actions
Copy link
Copy Markdown

✅ Synchronized metadata from Issue #1676:

  • Labels: level 1, recode, Enhacement, gssoc:approved, type:docs, type:design
  • Milestone: recode:launch 3.0

@github-actions
Copy link
Copy Markdown

✅ Synchronized metadata from Issue #1676:

  • Labels: level 1, recode, Enhacement, gssoc:approved, type:docs, type:design
  • Milestone: recode:launch 3.0

@hrx01-dev
Copy link
Copy Markdown
Contributor Author

@sanjay-kv I have fixed the conflicts.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
recode-website Ready Ready Preview, Comment May 24, 2026 1:16pm

@sanjay-kv sanjay-kv merged commit 1caf13e into recodehive:main May 24, 2026
6 checks passed
@sanjay-kv
Copy link
Copy Markdown
Member

@hrx01-dev awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhacement gssoc26 label gssoc:approved gssoc label in-review The current changes are in review and would need approval and testing before merging level 1 10 points recode this is label for leaderboard type:design gssoc labels 10pts type:docs gssoc label 5pts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dual color on dark mode on doc content

2 participants