Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API search] records data model returns extra fields #1094

Closed
frascuchon opened this issue Feb 3, 2022 · 0 comments · Fixed by #1095
Closed

[API search] records data model returns extra fields #1094

frascuchon opened this issue Feb 3, 2022 · 0 comments · Fixed by #1095
Assignees
@frascuchon
Labels
area: server Indicates that an issue or pull request is related to the server type: bug Indicates an unexpected problem or unintended behavior

Comments

@frascuchon
Copy link
Member

frascuchon commented Feb 3, 2022 •
edited
Loading

Record data model returned by search API returns more fields than documented: annotated_as, predicted_by, .... are returned but clients can easily computed using annotation/prediction info.
@frascuchon frascuchon added type: bug Indicates an unexpected problem or unintended behavior area: server Indicates that an issue or pull request is related to the server labels Feb 3, 2022
@frascuchon frascuchon self-assigned this Feb 3, 2022
@frascuchon frascuchon mentioned this issue Feb 3, 2022
Merged
frascuchon pushed a commit that referenced this issue Feb 7, 2022
fix(#1094): remove computed record fields returned in API results (#1095
e0e9a67 
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop
frascuchon pushed a commit that referenced this issue Feb 7, 2022
fix(#1094): remove computed record fields returned in API results (#1095
80e1aea 
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop

(cherry picked from commit e0e9a67)
frascuchon pushed a commit that referenced this issue Feb 7, 2022
fix(#1094): return empty list for no predicted_as (#1107)
78c03ea 
* fix: return empty list for no predicted_as

* test: add tests
frascuchon pushed a commit that referenced this issue Feb 7, 2022
fix(#1094): remove computed record fields returned in API results (#1095
fd2b91a 
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop

* fix: return empty list for no predicted_as

* test: add tests

(cherry picked from commit 78c03ea)

(cherry picked from commit e0e9a67)
frascuchon pushed a commit that referenced this issue Feb 7, 2022
fix(#1094): remove computed record fields returned in API results (#1095
053d654 
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop

* fix: return empty list for no predicted_as

* test: add tests

(cherry picked from commit 78c03ea)

(cherry picked from commit e0e9a67)
frascuchon pushed a commit that referenced this issue Feb 10, 2022
fix(#1094): remove computed record fields returned in API results (#1095
cd61d1e 
)

* fix: remove computed record fields returned in API results

* test: add tests

* fix: remove unnecessary pop

* fix: return empty list for no predicted_as

* test: add tests

(cherry picked from commit 78c03ea)

(cherry picked from commit e0e9a67)
dvsrepo added a commit that referenced this issue Feb 10, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
8342b51 
* 'master' of https://github.com/recognai/rubrix: (26 commits)
  feat(#1061): unify records results title (#1111)
  refactor(#945): using new search service (#1117)
  fix(#1121):  Adjust search bar width (#1124)
  fix(#945): validate label for single label text classification dataset (#1123)
  docs: fix skweak images (#1120)
  fix(#831): Remove sort field when only one is applied (#1116)
  refactor(#945): add current search aggregations as metrics (#1115)
  chore(#982): extends search area (#1112)
  chore(#1054): long records margin adjustment #1114
  feat(#1063): Token Classifier fine tuning content selection (#1084)
  refactor(#1102): remove "Update Summary" button rules summary (#1110)
  refactor(#945): revert index config for text2text (#1108)
  fix: convert pd.NaT to None for event_timestamp (#1105)
  fix(#1094): return empty list for no predicted_as (#1107)
  docs(#1089): remove pip install elasticsearch from docs (#1104)
  fix(#1054): reduce collapsable area. Optimize for annotation (#1106)
  fix(#945): include default aggregations for text2text (#1097)
  refactor(#1044): include last updated field for sort (#1093)
  fix(#1094): remove computed record fields returned in API results (#1095)
  feat(#1051): keep predictions labels when annotating (#1077)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
area: server Indicates that an issue or pull request is related to the server type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1094): remove computed record fields returned in API results argilla-io/argilla
1 participant
@frascuchon