Skip to content

Added Azure module for a private endpoint#369

Merged
tom-reinders merged 2 commits intodevelopfrom
feature/added-private-link
Oct 16, 2023
Merged

Added Azure module for a private endpoint#369
tom-reinders merged 2 commits intodevelopfrom
feature/added-private-link

Conversation

@pipalmic
Copy link
Copy Markdown
Contributor

No description provided.

@pipalmic pipalmic requested a review from a team October 16, 2023 06:54
Copy link
Copy Markdown
Contributor

@tom-reinders tom-reinders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few improvements, the rest looks great!

Comment thread modules/azure/private_endpoint/main.tf Outdated
Comment thread modules/azure/private_endpoint/variables.tf Outdated
Comment thread modules/azure/private_endpoint/main.tf Outdated
Comment thread modules/azure/private_endpoint/variables.tf Outdated
@pipalmic
Copy link
Copy Markdown
Contributor Author

Good points, that will make it even a bit more generic, updated.

@tom-reinders tom-reinders added this to the v3.12.0 milestone Oct 16, 2023
@tom-reinders tom-reinders merged commit ec1ab1d into develop Oct 16, 2023
@tom-reinders tom-reinders deleted the feature/added-private-link branch October 16, 2023 09:28
This was referenced Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants