Add flag for allowing status updates even when resource is being deleted #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-su
force-pushed
the
andrew-su/deletion-patch
branch
from
7e6aa85 to
669a96c
Compare
scothis
reviewed
Feb 5, 2025
Member
scothis
left a comment
scothis
left a comment
There was a problem hiding this comment.
Looks good. One minor suggestion on naming.
Signed-off-by: Andrew Su <suan@vmware.com>
andrew-su
force-pushed
the
andrew-su/deletion-patch
branch
from
669a96c to
8aed7aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
=======================================
Coverage 58.26% 58.26%
=======================================
Files 33 33
Lines 3800 3800
=======================================
Hits 2214 2214
Misses 1492 1492
Partials 94 94 ☔ View full report in Codecov by Sentry. |
Member
|
thanks @andrew-su |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #585, this PR provides an opt-in for status updates during resource deletion.