Allow ResourceReconciler to skip processing #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two hooks that will suppress the reconciliation: - SkipRequest: no work is preformed - SkipResource: the resource is loaded and defaulted Favor SkipRequest if a decision can be made based solely on the Namespace or Name. Use SkipResource if context of the resource is needed. The context is initialized before either call, allowing access to a client or logger. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 59.15% 59.29% +0.14%
==========================================
Files 35 35
Lines 4047 4061 +14
==========================================
+ Hits 2394 2408 +14
Misses 1555 1555
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamachanko
suggested changes
Mar 22, 2025
Co-authored-by: Max Brauer <mamachanko@users.noreply.github.com> Signed-off-by: Scott Andrews <scott@andrews.me>
mamachanko
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two hooks that will suppress the reconciliation:
Favor SkipRequest if a decision can be made based solely on the Namespace or Name. Use SkipResource if context of the resource is needed.
The context is initialized before either call, allowing access to a client or logger.